[#14226] - improve en-GB.localise.php
- Closed
- 24 Feb 2017
- Medium
- Build: staging
- # 14226
- Diff
- zero-24:improveen-GB.localise.php
User tests: Successful: Unsuccessful:
Summary of Changes
Just reduces if else elseif's
Testing Instructions
Go to the backend and publush on article, publish 2 articles and publuch mire than two articles
Expected result
Should still work
Actual result
Works
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Language & Strings |
Code looks fine, however you would have to do the same in the corresponding admin file.
Not sure how useful it is. It's not like the elseif here is overly complex
it's ok as it is imho. no use to change.
Actually for English it should change. By default, the pluralizer already has suffixes for the count, so it can be simplified to this:
return $count > 1 ? array('MORE') : array();(there's no need to add a second suffix to the array for the actual numbers, the logic only needs suffixes for specific pluralization rules and the resulting key ends up as something like COM_COMPONENT_STRING_MORE.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-24 16:00:16 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
?
?
|
||
I have tested this item✅ successfully on 8126ae9
1 article published.
2 articles published.
3 articles published.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14226.