? ? ? ? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
24 Feb 2017

Pull Request for Issue #14200 .

Summary of Changes

Replaces the list of <filename>en.GB.foo.ini</filename> with a single <folder>/</folder> tag.

Testing Instructions

  • Download an language pack of your choice and edit both install.xml files within it with this change.
  • Install the pack, check that it worked (eg all files are copied as expected)
  • Uninstall the pack and verify the files are removed

Documentation Changes Required

Documentation for creating a language pack should be adjusted.
https://docs.joomla.org/J3.x:Making_a_Language_Pack_for_Joomla#an_install.xml

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
5.00

avatar Bakual Bakual - open - 24 Feb 2017
avatar Bakual Bakual - change - 24 Feb 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Feb 2017
Category Administration Language & Strings
avatar Bakual
Bakual - comment - 24 Feb 2017

Example German language pack:
pkg_de-DE.zip

A more complex language like Persian would have to be a bit more creative since it also has media files which shouldn't end up in the language folder. Have a look at the site folder to see how it's done:
pkg_fa-IR.zip

avatar brianteeman
brianteeman - comment - 12 Mar 2017

Makes a lot of good sense to me

avatar alikon alikon - test_item - 15 Mar 2017 - Tested successfully
avatar alikon
alikon - comment - 15 Mar 2017

I have tested this item successfully on f2f6f62


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14228.

avatar horus68
horus68 - comment - 18 Apr 2017

Any reason why this is not merged yet?

avatar zero-24
zero-24 - comment - 18 Apr 2017

@horus68 you can use that in your language pack. As no core change is needed that this work.

avatar Bakual
Bakual - comment - 18 Apr 2017

Any reason why this is not merged yet?

@horus68 Mainly only one person which tested it. We usually want to have two people.

avatar zero-24
zero-24 - comment - 18 Apr 2017

Also i think for the core supplyed version we can still use the current way this makes it clear which files has been added using the history ?

avatar horus68
horus68 - comment - 18 Apr 2017

@zero-24 I don't see the point to have such list. There is no other place in the Project with a list of added files for any other part of the code, just for languages. If redundant, remove.
The main reason to remove its the way Crowdin works: every time a file is added all the XML translations are messed up, and we need to delete previous and translate again (every file needs to have our language code) and it take me 5 to 15 minutes each time there is a change in XML from Git.

  • If I do not translate all XML files (if my translations is not 100% ) I'm not able to download it from Crwodin.
  • So there is no use on creating a local version of the XML.
    Actually I create my language zip pack directly from Crowdin, no other edits are required.

All I want is to work the minimum required to have a great translation.

avatar zero-24
zero-24 - comment - 18 Apr 2017

Than @Bakual needs to fix the conflicts and you need to test this PR ?

avatar Bakual Bakual - change - 18 Apr 2017
Labels Added: ? ? ?
avatar Bakual
Bakual - comment - 18 Apr 2017

Rebased the PR and fixed the conflicts.

avatar horus68
horus68 - comment - 19 Apr 2017

@zero-24 tested: installed and uninstalled ok. All working, all files installed, no files or folder left behind after uninstall.
Joomla 3.7.rc3 / Firefox latest on Windows 10 / Wampserver apache 2.4.18
PHP 5.6.18 and 7.0.11 / MYSQL 5.6.17

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 Apr 2017

@horus68 can i set this as succesfully Test?

avatar horus68
horus68 - comment - 19 Apr 2017

@franz-wohlkoenig yes indeed!

avatar franz-wohlkoenig franz-wohlkoenig - alter_testresult - 19 Apr 2017 - horus68: Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 Apr 2017

@horus68 thanks, done in Tracker.

avatar rbuelund rbuelund - test_item - 19 Apr 2017 - Tested successfully
avatar rbuelund
rbuelund - comment - 19 Apr 2017

I have tested this item successfully on 4130212

Works perfectly on J3.7 RC-3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14228.

avatar franz-wohlkoenig franz-wohlkoenig - change - 20 Apr 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 Apr 2017

RTC after two successful tests.

avatar infograf768
infograf768 - comment - 20 Apr 2017

I am still concerned about this change:
We may get extraneous files installed in the language folders if a TT is negligent (simple example are .bak files, not a big deal, but can be worse).
Please do not reply that a TT should not be negligent...
For Persian and Dari using specific calendars, I guess it would not be a problem if their specific js is also present in the language xx-XX folder.

avatar dgt41
dgt41 - comment - 20 Apr 2017

For Persian and Dari using specific calendars, I guess it would not be a problem if their specific js is also present in the language xx-XX folder.

That shouldn't be the case with the new calendar, all files are already shipped by Joomla at media/system/js/fields/calendar-lacales

avatar infograf768
infograf768 - comment - 20 Apr 2017

That shouldn't be the case with the new calendar, all files are already shipped by Joomla at media/system/js/fields/calendar-lacales

Nope. They still need their own js for the dates displayed in the columns and wherever dates are displayed (Created,etc.) as the new calendar only concerns the date fields.

avatar stellainformatica
stellainformatica - comment - 20 Apr 2017

I am still concerned about this change:
We may get extraneous files installed in the language folders if a TT is negligent (simple example are .bak files, not a big deal, but can be worse).
I agree with JM

avatar mbabker
mbabker - comment - 20 Apr 2017

We may get extraneous files installed in the language folders

By that logic we should deprecate the <folder> tag for all extension adapters because this is an issue for all extension types and the only person able to do something about it is whomever is creating the package. So yes, it does mean that the packager has an additional responsibility to get things right.

avatar Bakual
Bakual - comment - 20 Apr 2017

For Persian and Dari using specific calendars, I guess it would not be a problem if their specific js is also present in the language xx-XX folder.

They could use a slightly different package structure and XML file to prevent that.
Or of course still create the list of files as it is currently (com_localise does that automatically), that will always work.

avatar syntaxerror
syntaxerror - comment - 27 Apr 2017

Tested successfully on Joomla 3.7, all files installed and uninstalled correctly.

We may get extraneous files installed in the language folders

As stated by others this is not any valid reason for not doing it. If translators is unable to make a language pack themselves, they should really start using tools who can automate this for them, or else someone has to do it for them. It's a bigger concern to me that people are still struggling with getting the darn install.xml right, no mater how they make their packs. It's just a pain in the ...

avatar rdeutz rdeutz - change - 22 May 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-22 18:10:30
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 22 May 2017
avatar rdeutz rdeutz - merge - 22 May 2017

Add a Comment

Login with GitHub to post a comment