? ? Pending

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
5 Feb 2017

Summary of Changes

With the social packages being deprecated in favor of the Framework counterparts, the JOAuth*Client classes no longer have a use in core. Similarly, the 4.0 branch is now in a state where the client class dependencies can be fulfilled by CMS classes. So, I'd like to propose deprecating these client classes in favor of consuming the Framework counterparts, similar to what has been happening with many other classes.

Testing Instructions

Maintainer decision.

Documentation Changes Required

The deprecation should be documented.

avatar mbabker mbabker - open - 5 Feb 2017
avatar mbabker mbabker - change - 5 Feb 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Feb 2017
Category Libraries
avatar wilsonge wilsonge - change - 5 Feb 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-02-05 22:20:04
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge wilsonge - close - 5 Feb 2017
avatar wilsonge wilsonge - merge - 5 Feb 2017
avatar wilsonge
wilsonge - comment - 5 Feb 2017

We should bundle the framework classes in 4.x in my opinion as they are much more useful than just the social media classes

avatar mbabker
mbabker - comment - 5 Feb 2017

Feel free to change the deprecation messages to note they'll be replaced.
Just so it's said publicly, the CMS can't be made compatible with the
Framework classes in 3.x so it'll be a "hard" B/C break in 4.0 either way.

On Sun, Feb 5, 2017 at 4:20 PM George Wilson notifications@github.com
wrote:

We should bundle the framework classes in 4.x in my opinion as they are
much more useful than just the social media classes


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#13937 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfoRHR7tDhMpMCCsDW6f22numzHNTCks5rZksjgaJpZM4L3kVx
.

--

  • Michael Please pardon any errors, this message was sent from my iPhone.
avatar wilsonge
wilsonge - comment - 5 Feb 2017

Done with 80b181f

Add a Comment

Login with GitHub to post a comment