? ? Pending

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
5 Feb 2017

Summary of Changes

JClientLdap and Joomla\Ldap\LdapClient are the same code minus some private stuff refactored for code style compliance. Let's just use that now and not duplicate a few lines of code.

Testing Instructions

LDAP authentication still works.

Documentation Changes Required

Note that JClientLdap is deprecated.

avatar mbabker mbabker - open - 5 Feb 2017
avatar mbabker mbabker - change - 5 Feb 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Feb 2017
Category External Library Libraries Front End Plugins
avatar laoneo
laoneo - comment - 6 Feb 2017

Should then JClientLdap not extend Joomla\Ldap\LdapClient?

avatar laoneo
laoneo - comment - 7 Feb 2017

Didn't see that. If I would have an Ldap environment I would test it ?

avatar wilsonge wilsonge - change - 14 Feb 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-02-14 16:19:57
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge wilsonge - close - 14 Feb 2017
avatar wilsonge wilsonge - merge - 14 Feb 2017

Add a Comment

Login with GitHub to post a comment