Joomla! Issue Tracker | Joomla! CMS #13936 - [4.0] Extend Framework's HTTP package

? ?

Fixed in Code Base
5 Feb 2017
Medium
Build: 4.0-dev
# 13936
Diff
mbabker:4.0-framework-http

Pending

User tests: Successful: Unsuccessful:

mbabker
5 Feb 2017

Summary of Changes

This PR makes the JHttp class set extend the Framework's HTTP package for 4.0. This should improve interoperability with the Framework packages as now the CMS' HTTP adapters will be compatible with the Framework (mainly affects the OAuth and social packages, the latter having been removed from the CMS).

This backports some structural changes from the Framework's package as well. First, the requirement that the options parameter be a Registry object being loosened to an array or ArrayAccess implementation (Registry does implement this). Next, transports aren't typehinted to JUri now but the Joomla\Uri\UriInterface. Lastly, this now results in PSR-7 compatible response objects being used.

Testing Instructions

The HTTP API should continue to function correctly.

Documentation Changes Required

There is a B/C break in the transport implementations, the signature for the request method now uses the Framework's Joomla\Http\TransportInterface::request() signature (the typehint of the URI object is changed from JUri to Joomla\Uri\UriInterface).