Can you send your changes as PR than?

Never done a PR, I test not code ;-)

On 1/22/2017 7:54 PM, zero-24 wrote:

Can you send your changes as PR than?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#13678 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHzLNjK9V9Jzgv8R6xzZegUAKA8xvYWhks5rU1F8gaJpZM4LqTlZ.

It is not that complicated as you might think. This way the change is also linked to your github history https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests

It is easy and simple feel free to contact me on any issues e.g. via Glip :)

I do not agree with changing this in core.
Not everyone is using the flags over a search box and it is easy to adapt these core css to your needs by overriding them in a custom.css by eventually adding a class or not.
The other aspect is that you define a padding for LTR which would not work for RTL

BTW, when displaying the module for example in the right column in protostar, this is what I get.
Left is before, right after the proposal:

Now you certainly understand why we should not change the default css.

I see what you mean but it works well when you just change the padding
but not the spacing indeed. That avoids the effect what you (correctly)
show

On 1/22/2017 10:39 PM, infograf768 wrote:

BTW, when displaying the module for example in the right column in
protostar, this is what I get.
Left is before, right after the proposal:

screenshot
https://cloud.githubusercontent.com/assets/869724/22183543/3b423086-e0c1-11e6-9891-3de397ceb523.png

Now you certainly understand why we should not change the default css.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#13678 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHzLNmhElJBNT8Hh_ZXHjxObHT6klS15ks5rU3hNgaJpZM4LqTlZ.

It looks better using Use Image Flags: No, but its not a Solution.

better look using smart-search:


no solution if wanna use "Search".

Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/13678

closed as having Pull Request #21254