? Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
22 Jan 2017

Pull Request for Issue # .

Summary of Changes

This PR makes some small cleanup to legacy controller + model classes:

  1. JControllerForm
  • Allow using column alias for checked_out field in JTable object
  • Remove unused $lang variable
  1. JModelAdmin
  • Replace deprecated JArrayHelper class with Joomla\Utilities\ArrayHelper
  • Allow using column alias for checked_out field in JTable object
  1. JModelList
  • Replace deprecated JArrayHelper class with Joomla\Utilities\ArrayHelper
  • Replace deprecated JDispatcher class with JEventDispatcher

Testing Instructions

  • For developers, please help review the code
  • For testers, please add/edit article, make sure it is still working as expected

Documentation Changes Required

None

avatar joomdonation joomdonation - open - 22 Jan 2017
avatar joomdonation joomdonation - change - 22 Jan 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Jan 2017
Category Libraries
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 22 Jan 2017

I have tested this item successfully on b9f1e6b

Add and edited article, still working as expected.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13679.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 22 Jan 2017 - Tested successfully
avatar wilsonge wilsonge - change - 22 Jan 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-01-22 10:24:33
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 22 Jan 2017
avatar wilsonge wilsonge - merge - 22 Jan 2017
avatar joomdonation
joomdonation - comment - 22 Jan 2017

Many thanks for testing and merging.

Add a Comment

Login with GitHub to post a comment