[#13677] - Disabled and readonly properties to the color formfied
- Fixed in Code Base
- 22 Jan 2017
- Medium
- Build: staging
- # 13677
- Diff
- Bakual:FixDisabledStateForColorField
User tests: Successful: Unsuccessful:
Pull Request for Issue #13665.
Summary of Changes
Adds proper disabled and readonly properties to the HTML element of the color formfield.
Testing Instructions
- Try a custom field of the type color and set the disabled state for it (or don't allow editing the value using the ACL).
- You can also try it by editing a form XML file and add a disabled attribute there. Eg add
disabled="disabled"to https://github.com/joomla/joomla-cms/blob/staging/templates/protostar/templateDetails.xml#L55 and try editing the color of the Protostar template.
Limitations
The readonly state doesn't do anything because the JS color picker doesn't support that. I have still added it to the HTML element in case someone overrides the color picker with one that works.
There is also a "simple" mode for that picker which can be activated by adding control="simple" to the form XML, but that doesn't seem to support the disabled state at all.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
| Labels |
Added:
?
|
||
I have tested this item
Would love to see the values more XML compliant.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13677.
Would love to see the values more XML compliant.
I prefer it this way and actually copied it from another field.
I have tested this item
Tested only Fieldtype "Color" on com_user.
If
- Disabled: No
- Read-Only: Yes
you can pick a color, mouse is shown as circle with line (forbidden?) over field, value gets saved.
- Disabled: Yes
- Read-Only: Yes
you cannot pick a color, mouse is also shown as circle with line.
- Disabled: No
- Read-Only: No
you can pick and write a color, mouse is shown as Textcurser.
I understand "Disabled: Isn't shown at Userprofil" and "Read-Only: Is shown, but not changeable".
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13677.
AS I wrote in the PR description, "readonly" doesn't work because the color picker JavaScript doesn't support it. That would have to be fixed upstream in that library.
The disabled toggle works as expected. It still is shown but it prevents manipulating the field and when the form is sent, the value isn't sent with it.
The difference between readonly and disabled is that with readonly the field value is still sent while with disabled the value isn't sent. For the user it is quite the same.
I have tested this item
Now i understand the "Limitations"-Paragraph.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13677.
zero-24
- | Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-22 14:53:23 |
| Closed_By | ⇒ | wilsonge | |
| Labels | |||
Thanks!
I have tested this item✅ successfully on 2d3c5c5
Would love to see the values more XML compliant.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13677.