? Pending

User tests: Successful: Unsuccessful:

avatar jajodiaraghav
jajodiaraghav
10 Jan 2017

Pull Request for Issue #13195 .

Summary of Changes

A long list of items in the sidebar menu of media manager was unreachable. A margin bottom fixes the issue

Documentation Changes Required

None

avatar jajodiaraghav jajodiaraghav - open - 10 Jan 2017
avatar jajodiaraghav jajodiaraghav - change - 10 Jan 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Jan 2017
Category Administration Templates (admin)
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 10 Jan 2017

I have tested this item ? unsuccessfully on eab161e

Tested at Joomla! 3.7.0-alpha2 (latest nightly): With or without PR sidebar menu can scroll down and see folder, which is clickable.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13548.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 10 Jan 2017 - Tested unsuccessfully
avatar jajodiaraghav
jajodiaraghav - comment - 11 Jan 2017

@franz-wohlkoenig So you mean this change is not required?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 11 Jan 2017

@jajodiaraghav In my environment (macOS Sierra, 10.12.2, Firefox 50.1.0) i see no diferenc with, -out Patch. So i see it not required like described in #13195.
I can click on folder, Name is not shown:
bildschirmfoto 2017-01-11 um 07 45 37
It would be better to see the name of the folder too. But that wass not the Point of #13195.

avatar infograf768
infograf768 - comment - 12 Jan 2017

@franz-wohlkoenig
One needs many more folders to see the issue.
Also 36px margin is not solving the issue;

screen shot 2017-01-12 at 12 01 48

Also, a css patch should be done in both .less files and CLI generatecss.php has to be used.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 Jan 2017

I assumed 50 Folders on different Levels are "A long list of items…".

avatar infograf768
infograf768 - comment - 12 Jan 2017

We should be able to see the folder name which we can't. I am afraid we need more than this margin.

avatar infograf768
infograf768 - comment - 12 Jan 2017

the solution is not in the margin but the padding here

To test, just change padding bottom:

.j-sidebar-container {
	position: absolute;
	display: block;
	left: -16.5%;
	width: 16.5%;
	margin: -10px 0 0 -1px;
	padding-top: 28px;
	padding-bottom: 40px; ////INSTEAD of 10px
	clear: both;
	background-color: #F0F0F0;
	border-bottom: 1px solid #dedede;
	border-right: 1px solid #dedede;
	-webkit-border-radius: 0 0 3px 0;
	-moz-border-radius: 0 0 3px 0;
	border-radius: 0 0 3px 0;
}```
avatar infograf768
infograf768 - comment - 12 Jan 2017

screen shot 2017-01-12 at 12 26 37

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 Jan 2017

@infograf768 With or without Patch same:
bildschirmfoto 2017-01-12 um 13 25 29

avatar jajodiaraghav
jajodiaraghav - comment - 12 Jan 2017

Changing padding-bottom fixes the problem in my case. Here's a screenshot:
capture

avatar infograf768
infograf768 - comment - 12 Jan 2017

Have you manually changed the css for Isis the way I posted?

avatar infograf768
infograf768 - comment - 12 Jan 2017

And cleared caches?

avatar jajodiaraghav
jajodiaraghav - comment - 12 Jan 2017

@infograf768
Yes and yes

avatar genesisfan
genesisfan - comment - 14 Jan 2017

I have tested this item ? unsuccessfully on eab161e

Changing the Isis css file recommended by @infograf768 did the trick, not the patch.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13548.

avatar genesisfan genesisfan - test_item - 14 Jan 2017 - Tested unsuccessfully
avatar jajodiaraghav jajodiaraghav - change - 14 Jan 2017
Labels Added: ?
avatar infograf768
infograf768 - comment - 14 Jan 2017

as i said above, changes have to be done in both less files and then generatecss has to be run

avatar infograf768
infograf768 - comment - 15 Jan 2017

Folks, I am going to make a new PR to replace this one as we also have issues in RTL for the sidebar display.

avatar infograf768
infograf768 - comment - 15 Jan 2017
avatar joomla-cms-bot joomla-cms-bot - close - 15 Jan 2017
avatar infograf768 infograf768 - change - 15 Jan 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-01-15 08:45:15
Closed_By infograf768
avatar infograf768
infograf768 - comment - 15 Jan 2017

Closing, replaced by #13593


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13548.

avatar joomla-cms-bot
joomla-cms-bot - comment - 15 Jan 2017

Add a Comment

Login with GitHub to post a comment