User tests: Successful: Unsuccessful:
Pull Request for Issue #13195 .
A long list of items in the sidebar menu of media manager was unreachable. A margin bottom fixes the issue
None
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Templates (admin) |
@franz-wohlkoenig So you mean this change is not required?
@jajodiaraghav In my environment (macOS Sierra, 10.12.2, Firefox 50.1.0) i see no diferenc with, -out Patch. So i see it not required like described in #13195.
I can click on folder, Name is not shown:
It would be better to see the name of the folder too. But that wass not the Point of #13195.
@franz-wohlkoenig
One needs many more folders to see the issue.
Also 36px margin is not solving the issue;
Also, a css patch should be done in both .less files and CLI generatecss.php has to be used.
I assumed 50 Folders on different Levels are "A long list of items…".
We should be able to see the folder name which we can't. I am afraid we need more than this margin.
the solution is not in the margin but the padding here
To test, just change padding bottom:
.j-sidebar-container {
position: absolute;
display: block;
left: -16.5%;
width: 16.5%;
margin: -10px 0 0 -1px;
padding-top: 28px;
padding-bottom: 40px; ////INSTEAD of 10px
clear: both;
background-color: #F0F0F0;
border-bottom: 1px solid #dedede;
border-right: 1px solid #dedede;
-webkit-border-radius: 0 0 3px 0;
-moz-border-radius: 0 0 3px 0;
border-radius: 0 0 3px 0;
}```
@infograf768 With or without Patch same:
Have you manually changed the css for Isis the way I posted?
And cleared caches?
@infograf768
Yes and yes
I have tested this item
Changing the Isis css file recommended by @infograf768 did the trick, not the patch.
Labels |
Added:
?
|
as i said above, changes have to be done in both less files and then generatecss has to be run
Folks, I am going to make a new PR to replace this one as we also have issues in RTL for the sidebar display.
Please test #13593
@jajodiaraghav
@genesisfan
@franz-wohlkoenig
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-15 08:45:15 |
Closed_By | ⇒ | infograf768 |
Closing, replaced by #13593
Set to "closed" on behalf of @infograf768 by The JTracker Application at issues.joomla.org/joomla-cms/13548
I have tested this item? unsuccessfully on eab161e
Tested at Joomla! 3.7.0-alpha2 (latest nightly): With or without PR sidebar menu can scroll down and see folder, which is clickable.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13548.