[#13547] - [com_fields] Catch "expects parameter 2 to be string" error
- Fixed in Code Base
- 12 Jan 2017
- Medium
- Build: staging
- # 13547
- Diff
- Digital-Peak:checkboxes-fix
User tests: Successful: Unsuccessful:
Pull Request for comment #13319 (comment).
Summary of Changes
No error should be shown when only the radio or checkboxes plugin contains options.
Testing Instructions
- Define options in the checkbox plugin.
- Create a checkbox custom field with no options.
Do the same for radio.
Expected result
No error should be shown and the options from the checkbox plugin should be selectable when editing an article. The selected options should also be shown on the front end.
The same result should be when using the radio custom field.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields |
My thought was that you can define some global options like an empty one which will appear then on every list field. Replacing would not make sense IMO as every field will have different use cases where it needs different options. But perhaps I'm wrong.
I was more thinking along the line to have a yes/no type set up in the plugin which will be the options for most radios and if I need something special I specify them in the field, overwriting the options from the plugin.
Sorry but I don't understand it right. Should we not open for that question a new issue and getting this one in?
Yeah, I'm opening a new issue for that.
I have tested this item
Test OK
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13547.
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13547.
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-12 11:04:04 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on dec96ec
The error is gone and the options set in the plugin show up.
Is it expected that options set in the fields parameters are merged together with the plugin options? I would have epxected that the ones from the field replace the ones from the plugin, not that they get added to the list.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13547.