? ? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
10 Jan 2017

Pull Request for comment #13319 (comment).

Summary of Changes

Introduces a new list base plugin class where all list based plugins should extend from. When a plugin extends from another plugin class, then this one doesn't receive the triggered event. This was the cause why the list plugin was not available in the types plugin when creating a new field.

Testing Instructions

Create a new list custom field and check if it works as expected when editing an article and viewing on the front.

avatar laoneo laoneo - open - 10 Jan 2017
avatar laoneo laoneo - change - 10 Jan 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Jan 2017
Category Administration com_fields Front End Plugins
avatar Bakual
Bakual - comment - 10 Jan 2017

I have tested this item successfully on 182d460


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13546.

avatar Bakual Bakual - test_item - 10 Jan 2017 - Tested successfully
avatar zero-24 zero-24 - change - 10 Jan 2017
Labels Added: ?
avatar freshweb
freshweb - comment - 13 Jan 2017

I've tested this successfully on Joomla! 3.7.0-alpha2 dev, PHP 7.1.0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13546.

avatar laoneo
laoneo - comment - 13 Jan 2017

Guess we can set this to RTC.

avatar freshweb
freshweb - comment - 13 Jan 2017

Probably not the place to ask this but hey ho! Should the category assignment not be on the Field Group rather than on individual fields?

avatar Bakual
Bakual - comment - 13 Jan 2017

Probably not the place to ask this

Wrong place indeed. Open a new issue if you want to question that.

Should the category assignment not be on the Field Group rather than on individual fields?

No. Field Groups are basically just tabs. Having it on fields is more much flexible.

avatar laoneo
laoneo - comment - 16 Jan 2017

Can somebody please add the RTC label again. Thanks.

avatar infograf768 infograf768 - change - 16 Jan 2017
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 16 Jan 2017

Done


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13546.

avatar laoneo
laoneo - comment - 16 Jan 2017

Thanks

avatar rdeutz rdeutz - change - 16 Jan 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-01-16 09:56:14
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 16 Jan 2017
avatar rdeutz rdeutz - merge - 16 Jan 2017

Add a Comment

Login with GitHub to post a comment