Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#13545] - Fixes #13177: Added where clause with block state

? ? Pending

User tests: Successful: Unsuccessful:

avatar jajodiaraghav
jajodiaraghav
10 Jan 2017

Pull Request for Issue #13177 .

Summary of Changes

Added where clause to check User's block state to prevent registration notification emails to be sent to users who are blocked.

Testing Instructions

[added by @zero-24]

  • Install joomla
  • set registration mal to admin
  • add a user with System Mail => Yes that is blocked
  • try to register
  • confirm that all 3 the mails still get out but also to the blocked admin
  • apply this patch
  • confirm that the 3 mails only get out for the non-blocked admin

Documentation Changes Required

None

avatar jajodiaraghav jajodiaraghav - open - 10 Jan 2017
avatar jajodiaraghav jajodiaraghav - change - 10 Jan 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Jan 2017
Category ⇒ Front End com_users
avatar zero-24 zero-24 - change - 10 Jan 2017
The description was changed
avatar zero-24 zero-24 - edited - 10 Jan 2017
avatar zero-24 zero-24 - change - 10 Jan 2017
Labels Added: ?
avatar zero-24
zero-24 - comment - 10 Jan 2017

@jajodiaraghav thanks for your patch i have just added test instructions and updated to staging.

avatar joomdonation
joomdonation - comment - 15 Jan 2017

The issue is valid and this PR fixed it. However, please make small improvement to the code. I think we don't need (int) 0; in the code

So the code could be change to:

$query->clear()
	->select($db->quoteName(array('name', 'email', 'sendEmail', 'id')))
	->from($db->quoteName('#__users'))
	->where($db->quoteName('sendEmail') . ' = 1')
	->where($db->quoteName('block') . ' = 0');

Once you made the change, I will mark my test result as success.

avatar jajodiaraghav
jajodiaraghav - comment - 15 Jan 2017

@joomdonation I have updated the commit. Thank you for the guidance.
Also Sir, since i am new to Joomla-cms, it would be great if you could guide be to the issues that i could work on, and the links to location where i can talk to the people involved with the Joomla! community.

avatar joomdonation
joomdonation - comment - 16 Jan 2017

I have tested this item ✅ successfully on a8fe9fa

on code review.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13545.

avatar joomdonation joomdonation - test_item - 16 Jan 2017 - Tested successfully
avatar joomdonation
joomdonation - comment - 16 Jan 2017

@jajodiaraghav Thanks for willing to contribute more to Joomla. In short, you can see list of issues here https://github.com/joomla/joomla-cms/issues which you can work on

You can also help testing pull requests at https://github.com/joomla/joomla-cms/pulls

For more details, I think you can read this topic https://groups.google.com/forum/#!topic/joomla-dev-general/6t5gbEpaY18

avatar jajodiaraghav
jajodiaraghav - comment - 16 Jan 2017

Thanks a lot ? @joomdonation

avatar zero-24
zero-24 - comment - 16 Jan 2017

I have tested this item ✅ successfully on a8fe9fa

?

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13545.

avatar zero-24 zero-24 - change - 16 Jan 2017
Milestone Added:
Status Pending ⇒ Ready to Commit
avatar zero-24 zero-24 - change - 16 Jan 2017
Labels Added: ?
avatar zero-24 zero-24 - test_item - 16 Jan 2017 - Tested successfully
avatar rdeutz rdeutz - close - 17 Jan 2017
avatar rdeutz rdeutz - merge - 17 Jan 2017
avatar rdeutz rdeutz - change - 17 Jan 2017
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-01-17 10:40:38
Closed_By ⇒ rdeutz
Labels

Add a Comment

Login with GitHub to post a comment