[#13549] - Fixing Showon in plugins/modules/templates
- Fixed in Code Base
- 14 Jan 2017
- Medium
- Build: staging
- # 13549
- Diff
- Bakual:FixShowon
User tests: Successful: Unsuccessful:
Pull Request for Issue #13540.
Summary of Changes
The method JFormHelper::parseShowOnConditions was missing the field group.
I have added that group as an argument to the method.
I also changed the argument order so $showOn is first. $formControl and $group come afterwards and are optional (since the code works without them).
Testing Instructions
Test showon behaviour in the various places. Some examples:
- Component Options - com_content - "Show Title"
- Module - Login - "Show Greeting"
- Plugin - CAPTCHA - reCAPTCHA - "Version"
- Template - Protostar - "Google Font for Headings"
- Global Configuration - "Enable FTP"
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_config Layout Libraries |
| Labels |
Added:
?
?
|
||
you have conflicts.
No, it was just a codestyle issue (line to long). Fixed now.
anyway i was working on a alternative solution that also allows to extend showon across to multiple fieldsets/groups
Personally, I think if your showon is going to change something in another fieldset, then your UX needs to be improved
I have tested this item
Tested like this:
-
Installed Staging of today.
-
Add New Menu Item "Add Article"
-
- Menu Item Type: Articles > Create Article
-
- Tab "Options": Set "Default Category": YES
-
- Showon should show now the field "Choose a Category (enable_category)" but doesn't.
-
Applied this patch PR13549. All fine.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13549.
I have tested this item
Tested like this:
-
Installed Staging of today.
-
Add New Menu Item "Add Article"
-
- Menu Item Type: Articles > Create Article
-
- Tab "Options": Set "Default Category": YES
-
- Showon should show now the field "Choose a Category (enable_category)" but doesn't.
-
Applied this patch PR13549. All fine.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13549.
I have tested this item
Test OK
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13549.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13549.
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-14 19:58:26 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
@Bakual you have conflicts.
anyway i was working on a alternative solution that also allows to extend showon across to multiple fieldsets/groups (using
.if needed - ex:params.show_title:1).If you are interrested see https://github.com/andrepereiradasilva/joomla-cms/pull/125/files