[#13476] - [showon] Allow "not in" condition and simplify php code
- Fixed in Code Base
- 6 Jan 2017
- Medium
- Build: staging
- # 13476
- Diff
- andrepereiradasilva:more-showon
User tests: Successful: Unsuccessful:
Pull Request for Improvement.
Summary of Changes
This PR does two things:
- Add a new "not in" condition to shown, we can use this condition by making use of the
!:operator, insteadd of the normal:. This is particular useful if you want to put, for instance: field A should show on when fieldB value is not empty, ie,showon="fieldB!:", which is not possible without this PR
Example:
// - Current
// Field A with value in 1 OR field B with value IN 1, 2 or 3
fieldname:1[OR]fieldB:1,2,3
// - NEW
// Field A with value in 1 OR field B with value NOT IN 1, 2 or 3
fieldname:1[OR]fieldB!:1,2,3- Normalizes showon php code across the core. Remvoe a lot of duplicated code.
Testing Instructions
- Apply patch
- Confirm current fields with showon behaviour continue to work fine
- Change this line line in com_config xml so the showon condition is
mailonline:1[AND]mailer!:smtp.
Now check this field will appear when the fieldmailonlineis set to yes and the mailer is different than smtp. - Make any other tests you can remember
Documentation Changes Required
Add this new operator to https://docs.joomla.org/Form_field#Showon
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_config Layout Libraries JavaScript |
This should be an easy simple test.
I plan to make one more upgrade to shown js (allow showon on global values), but can only do this after this is merged.
So if you have 5 minutes please test.
This seems doesn't work well. After applying the patch, in Global Configuration, Mail Settings section, if we choose SMTP, additional fields like SMTP Host, SMTP Port... are not being shown
| Labels |
Added:
?
|
||
@joomdonation probably a bug, will check
@joomdonation yeah it was a bug forgot to change a thing. should be solved now.
I have tested this item
Tested showon behavior in Global Configuration of Joomla. Before and after patch, the behavior is the same
Tested the new operator and it worked, too.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13476.
OK. I tested it and it seems works well. I only tested the behavior (using Google Chrome ), no code review.
I have tested this item
Test OK
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13476.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13476.
| Labels |
Added:
?
|
||
just remove a obvious bug a double json_enconde when using showon on fieldset. no need to remove RTC IMO
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-06 08:08:52 |
| Closed_By | ⇒ | rdeutz |
Documentation can be found here: https://docs.joomla.org/Form_field#Showon