? ? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
4 Jan 2017

PR #13256 changed the way the language installer works.
I forgot to remove the ordering option for ID which is now invalid.

Summary of Changes

Removes the options from the dropdown

Testing Instructions

  • Go to Extension -> Manage -> Install Languages
  • After applying this PR, the options to order by ID are no longer present.

Documentation Changes Required

None

avatar Bakual Bakual - open - 4 Jan 2017
avatar Bakual Bakual - change - 4 Jan 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Jan 2017
Category Administration com_installer
avatar RonakParmar
RonakParmar - comment - 5 Jan 2017

@Bakual I have attached before and after patch applied screen dumps please check them, Are they correct or not? So I can successfully test this PR. Because, You mentioned that after applying this PR, the options to order by ID are no longer present, still I can see ID option in drop-down.
Before PR:
screen shot 2017-01-04 at 22 30 05

After PR:
screen shot 2017-01-04 at 22 30 20


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13475.

avatar Bakual
Bakual - comment - 5 Jan 2017

Judging from the screenshots you need to update your local installation to current staging (or nightly) before applying the PR.
You still seem to have the old install view

avatar RonakParmar
RonakParmar - comment - 5 Jan 2017

I have tested this item successfully on bc17e6e

Downloaded latest Joomla staging branch and tested.
PR works fine.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13475.

avatar RonakParmar RonakParmar - test_item - 5 Jan 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 5 Jan 2017

I have tested this item successfully on bc17e6e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13475.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 5 Jan 2017 - Tested successfully
avatar zero-24 zero-24 - change - 5 Jan 2017
Milestone Added:
Status Pending Ready to Commit
Labels Added: ?
avatar rdeutz rdeutz - change - 5 Jan 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-01-05 19:43:42
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 5 Jan 2017
avatar rdeutz rdeutz - merge - 5 Jan 2017

Add a Comment

Login with GitHub to post a comment