[#13450] - Multilanguage: When installing Joomla the showon should be replaced by js
- Fixed in Code Base
- 3 Jan 2017
- Medium
- Build: staging
- # 13450
- Diff
- infograf768:multilang_showon
User tests: Successful: Unsuccessful:
Pull Request for Issue #13445
Issue: although the xml contains a showon, both multilang content and languagecode plugin fields are displayed.
Summary of Changes
Using js instead of showon in Joomla installation
Testing Instructions
Install Joomla as multilang.
Before patch, toggle will not work:
Patch and install again Joomla
Now you will get
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation |
this seems to work, but wouldn't it be better to make installation app render the showon when the field as that attribute? This way we would use always the same code.
example: https://github.com/joomla/joomla-cms/blob/staging/layouts/joomla/content/options_default.php#L29
a similar code is already used in https://github.com/joomla/joomla-cms/blob/staging/installation/view/summary/tmpl/default.php#L374
ok, i see, so the install app uses some custom toggle methods ... instead of using showon.
One worker of the build of this PR is stuck on Travis for 4 hours now and blocking. It's creating a backlog because of one less worker being used for the new ones. Can someone with write access to this repo kill restart that build, pls? see: https://travis-ci.org/joomla/joomla-cms/builds/188218803
| Status | Pending | ⇒ | Ready to Commit |
I guess we can be RTC this and merge as @andrepereiradasilva understood that we use custom toggle methods in install app. I don't have any more the Travis issue here.
@rdeutz thanks for merging
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13450.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-03 07:36:42 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
?
|
||
I have tested this item✅ successfully on 1005ed0
It now works, the 2 fields are toggled
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13450.