[#13451] - [Deprecate _QQ_ 3] Mark _QQ_ as deprecated and normalize language ini parsing
- Closed
- 9 May 2018
- Medium
- Build: staging
- # 13451
- Diff
- andrepereiradasilva:deprecate-qq
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Summary of Changes
As discussed in #13421
Deprecate _QQ_ and normalize parsing of ini language files.
- creates a new method JLanguageHelper::parseIniFile and marks LanguagesHelper::parseFile (helper of com_languages) as deprecated.
- makes the necessary adaptations
Testing Instructions
-
Apply patch
-
Check all language strings show as usual. Including the ones with
"_QQ_" -
Confirm language debug still works.
Enable debug language in global config and system debug plugin.manually make some parsing errors in the en-GB.ini file and reload the page -
Confirm language overrrides still works.
For instance, load a language string that uses escaped quotes (ex: JLIB_DATABASE_ERROR_DATABASE_UPGRADE_FAILED) and make some changes in the override. Save it and load it again to check if ok. -
Confirm quoting in server side and client side still works (ex: add to isis template index.php)
$app->enqueueMessage('Server side Test 1 (click to proceed to Client side Test 3): ' . JText::_('JLIB_DATABASE_ERROR_DATABASE_UPGRADE_FAILED'));
JText::script('JLIB_DATABASE_ERROR_DATABASE_UPGRADE_FAILED');
$this->addScriptDeclaration("alert('Client side Test 1: ' + Joomla.JText._('JLIB_DATABASE_ERROR_DATABASE_UPGRADE_FAILED'));");
$this->addScriptDeclaration("alert('Client side Test 2: " . JText::_('JLIB_DATABASE_ERROR_DATABASE_UPGRADE_FAILED', true) . "');");
$this->addScriptDeclaration("window.addEventListener('click', function () { Joomla.renderMessages({'error': ['Client side Test 3: ' + Joomla.JText._('JLIB_DATABASE_ERROR_DATABASE_UPGRADE_FAILED')]}) });");- Any other test you could remember
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_languages Libraries |
| Labels |
Added:
?
|
||
| Title |
|
||||||
| Title |
|
||||||
I have tested this item
Tested according to instructions: OK
Code review: OK
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13451.
Conflicts
conflicts fixed
I have tried locally to resolve the merge conflicts on this PR but I get
Error: Class 'Joomla\CMS\Language\JLanguageHelper' not found: Class 'Joomla\CMS\Language\JLanguageHelper' not found
I am guessing it is something to do with
creates a new method JLanguageHelper::parseIniFile and marks LanguagesHelper::parseFile (helper of com_languages) as deprecated.
Any clues?
Any calls to JLanguageHelper in the libraries/src directory should either be prefixed with a leading slash (i.e. \JLanguageHelper) or use the full namespaced class name (i.e. Joomla\CMS\Language\LanguageHelper).
Thanks. I will check it in the morning
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-05-09 08:01:23 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
?
|
||
@frankmayer please check