[#13449] - Move PHP 7 checks for MySQL adapter
- Fixed in Code Base
- 6 Jan 2017
- Medium
- Build: staging
- # 13449
- Diff
- mbabker:mysql-checks-improved
User tests: Successful: Unsuccessful:
Summary of Changes
Include PHP 7 version check in the MySQL adapter's isSupported() method and remove the hardcoded check for support in the base driver's getConnectors() method.
Testing Instructions
Plain "MySQL" still correctly shows (or doesn't) as an option for a database driver.
Documentation Changes Required
N/A
Extra Notes
The constructor check is explicitly left in place since it throws an Exception with an explicit message about the lack of environment support versus allowing the class to be instantiated and get through to the normal place where support is checked which results in a generic message.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
It doesn't pass unless you've got the polyfill that's floating around out there installed (which tries to proxy to the mysqli extension but anyone who knows the PHP API knows mysqli and mysql aren't compatible and no polyfill is going to fix that). But this still makes it very explicit that you just are not going to use this class on PHP 7.
I have tested this item
Test OK
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13449.
I have tested this item
Tested on 5.6 and 7.0
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13449.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-06 06:20:45 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
|
||
hmm just to be sure. Why did
function_exists('mysql_connect');pass on PHP 7.x? Is this not the real bug? As this function (mysql_connect) did not exists anymore in PHP 7 or do i miss something?