Feeling Lucky
?
[#13371] - Various changes in installation
- Fixed in Code Base
- 13 Jun 2017
- Medium
- Build: staging
- # 13371
- Diff
- frankmayer:Various-changes-in-installation
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
- Merge isset values instead of calling multiple times
- Merge nested ifs
- set return-values as expected by doc-blocks
- More performant string functions
- Decoupled object instantiation from foreach
- Inline one-time variable
The few changes in this PR should be fairly easy to review. No change in behavior is expected.
Testing Instructions
Code review only. No web- tests, should not change behavior.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-25 23:57:48 |
| Closed_By | ⇒ | frankmayer | |
| Labels |
Added:
?
|
||
| Status | Closed | ⇒ | Pending |
| Category | Installation | ⇒ | Installation JavaScript |
andrepereiradasilva
- comment
- 12 Jun 2017
I have tested this item
code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13371.
| Status | Pending | ⇒ | Ready to Commit |
franz-wohlkoenig
- comment
- 13 Jun 2017
RTC after two successful tests.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 2016-12-25 23:57:48 | ⇒ | 2017-06-13 13:30:34 |
| Closed_By | frankmayer | ⇒ | rdeutz |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on f36e8b8
Code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13371.