Feeling Lucky
?
[#13370] - [com_fields] Removal of unnecessary parentheses and usage of elvis operator in /administrator
- Fixed in Code Base
- 13 Jun 2017
- Medium
- Build: staging
- # 13370
- Diff
- frankmayer:unnecessary-parentheses-and-elvis
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Summary of Changes
- Remove unnecessary parentheses
- Use elvis operator!
The changes in this PR should be fairly easy to review. They are only removal of parentheses and uses of elvis instead of full ternary.
Testing Instructions
None, should not change behavior
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_categories com_config com_contact com_content com_cpanel com_fields com_finder com_installer com_joomlaupdate com_languages com_media com_menus |
| Title |
|
||||||
| Title |
|
||||||
| Labels |
Added:
?
|
||
| Category | Administration com_banners com_categories com_config com_contact com_content com_cpanel com_fields com_finder com_installer com_joomlaupdate com_languages com_media com_menus | ⇒ | Administration com_banners com_categories com_config com_contact com_content com_cpanel com_fields com_finder com_installer com_joomlaupdate com_languages com_menus |
| Category | Administration com_banners com_categories com_config com_contact com_content com_cpanel com_fields com_finder com_installer com_joomlaupdate com_languages com_menus | ⇒ | Administration com_banners com_categories com_contact com_content com_cpanel com_fields com_finder com_installer com_joomlaupdate com_languages com_menus |
| Title |
|
||||||
| Title |
|
||||||
laoneo
- comment
- 11 Apr 2017
Can you please solve the merge conflicts?
| Category | Administration com_banners com_categories com_contact com_content com_cpanel com_fields com_finder com_installer com_joomlaupdate com_languages com_menus | ⇒ | Administration com_banners com_categories com_contact com_content com_cpanel com_fields com_finder com_installer com_joomlaupdate com_languages com_menus com_modules |
frankmayer
- comment
- 26 Apr 2017
Conflicts resolved. Ready to be checked and merged.
Quy
- comment
- 28 May 2017
Quy
- comment
- 29 May 2017
I have tested this item
Code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13370.
andrepereiradasilva
- comment
- 31 May 2017
I have tested this item
on code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13370.
Quy
- comment
- 31 May 2017
I have tested this item
Code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13370.
| Status | Pending | ⇒ | Ready to Commit |
franz-wohlkoenig
- comment
- 1 Jun 2017
RTC after two successful tests.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-13 13:23:12 |
| Closed_By | ⇒ | rdeutz |
Conflicts resolved...