Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#13354] - Fix issue with TinyMCE editor

? Success

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
23 Dec 2016

Pull Request for Issue # .

Summary of Changes

This tiny PR fix a small issue with TinyMCE editor. The javascript code defined in tinymce.min.js use code defined in media/system/js/core.js, so we need to call JHtml::_('behavior.core'); in TinyMCE editor plugin before tinymce.min.js is loaded

Testing Instructions

  1. Configure your site to use Tiny MCE editor
  2. Open the file administrator/components/com_content/content.php, replace it with simple PHP code
echo JFactory::getEditor()->display('description', '', '100%', '180', '90', '6'); .

Access to Content -> Articles. Instead of seeing a HTML editor, you will only see a large textarea. If you look at the console of web browser, you will see this javascript error Uncaught ReferenceError: Joomla is not defined at tinymce-init.min.js:1

  1. Apply patch, the editor is being displayed properly, Javascript error is gone

Documentation Changes Required

None

avatar joomdonation joomdonation - open - 23 Dec 2016
avatar joomdonation joomdonation - change - 23 Dec 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Dec 2016
Category ⇒ Front End Plugins
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 5 Jan 2017

I have tested this item ? unsuccessfully on 4629d68

Got An error has occurred. 0 syntax error, unexpected '.', expecting end of file
after modified content.php to

/**
 * @package     Joomla.Administrator
 * @subpackage  com_content
 *
 * @copyright   Copyright (C) 2005 - 2016 Open Source Matters, Inc. All rights reserved.
 * @license     GNU General Public License version 2 or later; see LICENSE.txt
 */

echo JFactory::getEditor()->display('description', '', '100%', '180', '90', '6'); . ```<hr /><sub>This comment was created with the <a href="https://github.com/joomla/jissues">J!Tracker Application</a> at <a href="https://issues.joomla.org/tracker/joomla-cms/13354">issues.joomla.org/tracker/joomla-cms/13354</a>.</sub>
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 5 Jan 2017 - Tested unsuccessfully
avatar joomdonation
joomdonation - comment - 5 Jan 2017

Thanks for testing @franz-wohlkoenig

However, you are using the wrong code. Please use this correct code (please copy it directly here):

echo JFactory::getEditor()->display('description', '', '100%', '180', '90', '6');
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 5 Jan 2017

I have tested this item ✅ successfully on 4629d68

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13354.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 5 Jan 2017 - Tested successfully
avatar joomdonation
joomdonation - comment - 5 Jan 2017

Could someone help making another test? This is a backward incompatible issue. Below are the screenshot of a form in my extensions;

  1. In Joomla 3.6.5

3 6 5

  1. In 3.7.0

3 7 0

And as I mentioned before, there is an error in browser console Uncaught ReferenceError: Joomla is not defined at tinymce-init.min.js:1

I can easily add the command JHtml::_('behavior.core'); at the beginning of every form in my extesnions but I am worry that existing customers will get the issue when they update to 3.7.0. It is paid extension, so not everyone can update if their subscription expired.

avatar dgt41
dgt41 - comment - 5 Jan 2017

I have tested this item ✅ successfully on 4629d68

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13354.

avatar dgt41 dgt41 - change - 5 Jan 2017
Status Pending ⇒ Ready to Commit
avatar dgt41 dgt41 - test_item - 5 Jan 2017 - Tested successfully
avatar dgt41
dgt41 - comment - 5 Jan 2017

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13354.

avatar joomdonation
joomdonation - comment - 5 Jan 2017

Thanks for your help @dgt41

avatar zero-24 zero-24 - change - 5 Jan 2017
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-01-05 17:55:39
Closed_By ⇒ zero-24
avatar zero-24 zero-24 - close - 5 Jan 2017
avatar zero-24 zero-24 - merge - 5 Jan 2017
avatar zero-24
zero-24 - comment - 5 Jan 2017

Thanks ?

Add a Comment

Login with GitHub to post a comment