[#13353] - [com_fields] Store fields in 'com_fields' property instead of reusing 'params'
- Fixed in Code Base
- 10 Mar 2017
- Medium
- Build: staging
- # 13353
- Diff
- Bakual:ChangeParamsToComfields
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
This decouples a part of #13182 since we don't seem to get an agreement there anytime soon
Summary of Changes
- Store fields in 'com_fields' property instead of reusing the already existing 'params'. This eliminates possible conflicts.
- Show custom fields in frontend article edit using the joomla.edit.params JLayout.
- Adjusted the JLayout to take a custom tab name so it is reusable better. If no tab name is specified it uses the current behavior ('myTab').
Testing Instructions
- Test that you can still save values into custom fields both in frontend and backend.
- Inspect the HTML code and see that the ID attribute of the field has changed from
jform_params_aliastojform_com_fields_aliasand the name fromjform[params][alias]tojform[com_fields][alias].
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields Front End com_contact com_content Layout Plugins |
(Assuming you mean jform[com_fields][alias])
Of course! Adjusted the PR description now
I don't se the benefit for this change honestly? Params is made for custom fields, so why not reuse it?
Params is made for custom fields, so why not reuse it?
Because it's not made for custom fields. It's a groupd specified in many (if not most) extensions XML file to hold various item options.
That means in most cases there is already data in that group, and it's the reason you load the existing data, convert it, merge with com_fields data, process it, unset it and convert the original params data back. All while having the risk that we have conflicts with existing data.
Now if using our own group, we can eliminate the risk of having conflicts and don't need to convert and merge and convert back the existing data.
This PR is needed
Besides the obvious reason to avoid conflicts, there are more benefits
- since anyway they need to be seperated from params array, why add them there in the first place,
thus avoid the extra step to find the custom fields inside the 'params' and then clean-up the 'params' array before DB save
-
it makes easier to reference / handle them inside form via JS
-
easier to apply "different" validation of them ... in future if needed
-
also logically it makes sense since the 'params' are mostly non-content, and 'com_fields' are mostly 'content' ...
| Labels |
Added:
?
|
||
We have conflicts here.
Rebased and conflict solved.
Rebased and fixed conflicts (again)
Rebased and fixed conflicts once more
Please tag me if ready to test :)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13353.
@coolcat-creations It is ready for quite some time already
I will test too during weekend
I have tested this item
@Bakual sorry i should have read my errormessage :-D Test successful!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13353.
I will also have a look over the weekend, somehow I have the feeling something is missing.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13353.
RTC as there are 2 successfully Tests?
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13353.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-10 19:25:04 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on c8ff6d1
(Assuming you mean
jform[com_fields][alias])This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13353.