User tests: Successful: Unsuccessful:
Adds an id to the two login modules (frontend and backend). It follows the naming style of the other elements in the modules (...). This improves multi-language testability..
Code review
None.
Status | New | ⇒ | Pending |
Category | ⇒ | Modules Administration Front End |
Having an ID attribute in a module is actually bad idea as they may appear on a page multiple times and thus produce invalid HTML.
If you need an id (eg a class doesn't work for some reason), make sure to add the $module->id to the ID generation so you end up with an unique identifier.
@Bakual when you look at the two login modules, they have both already only hardcoded ids.. So it does not work already.. Else i would have made a class / use the module id, but as said i followed the module naming style.. Didn't want to clean up that ** with this PR :)
If you do something where the login module is rendered multiple times on the page, then you're technically generating invalid HTML with this as is because you'll have multiple DOM elements with the same ID. Although we already have this problem with both modules so ¯\_(ツ)_/¯
I don't care about existing IDs. They can be cleaned up with J4. But lets not introduce additional ones :)
Closing in favour of a class selector..
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-23 21:16:57 |
Closed_By | ⇒ | yvesh | |
Labels |
Added:
?
|
I have tested this item✅ successfully on 8657723
Code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13352.