[#13355] - Make ids unique on the frontend login module
- Closed
- 11 Sep 2017
- Medium
- Build: staging
- # 13355
- Diff
- yvesh:frontendloginmodule
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
User tests: Successful: Unsuccessful:
Summary of Changes
As discussed in #13352 the login module has hardcoded ids, so will invalidate any html markup when used multiple times on the page. This PR makes all ids unique using the module id and / or moves them into CSS class.
Testing Instructions
Check if mod_login is still working. Review source code
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
3 or 4, it depends :-)
- small chance that people use two login modules on one page
- small chance that some use the ids for styling
The bugfix weights higher for me as the "b/c" break
Also, "b/c" break for javascript
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13355.
@anibalsanchez how this can be, sounds strange?
I mean any extension using the IDs to play with the login fields will break if we remove them.
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
| Milestone |
Removed: |
||
Can you look at resolving the conflicts so that this can be tested please.
@brianteeman in Joomla 4 we want to have a general guideline / style on naming html locators (ids, classes etc.) with @ciar4n @C-Lodder @dgt41
// Closing because of that
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-09-11 14:33:33 |
| Closed_By | ⇒ | yvesh |
Can you do that against the 4.0 branch?
I don't think we should change them in the 3.x series or we would likely break existing template styling.