[#13326] - Multilanguage: Correcting login form redirect bug introduced in #12932
- Fixed in Code Base
- 22 Dec 2016
- Medium
- Build: staging
- # 13326
- Diff
- infograf768:multi_loginformredirect
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Testing Instructions
Create a default Multingual site from staging with 2 languages, for example en-GB and fr-FR.
Set default site language to en-GB.
Set default USER site language to fr-FR
Make sure that the language filter Automatic Language Change parameter is set to Yes as well as Item Associations.
In the en-GB main menu, create 2 new menu items.
The first one can be for example a Search menu item type. Search English
The second one will be a login form. Login English
In the fr-FR main menu, create 1 new menu item, can also be a Search menu item type. Search French
Associate this menu item to the en-GB one Search English
Edit the en-GB Login English menu item.
In the Options tab, select Menu item as Login Redirect Type.
Select the Search English menu item as Menu Item Login Redirect.
Save.
Go to the frontend en-GB Home page.
Display the Login English login form.
Log.
You are redirected to the Search English page.
THAT IS WRONG! It should redirect to the Search French associated menu item as the user preferred frontend language is fr-FR and Automatic language change is set to Yes.
Quote from code comments is
// The login form contains a menu item redirection. Try to get associations from that menu item.
// If any association set to the user preferred site language, redirect to that page.The issue comes from the fact that $itemid is undefined line 639 of languagefilter.php. Thsi error was introduced in my patch #12932 ... oops.
Now patch. You should be redirected to the correct page, i.e. "Search French"
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Title |
|
||||||
| Title |
|
||||||
| Category | Front End Plugins | ⇒ | Front End Multilanguage Plugins |
I have tested this item
patch ok
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13326.
| Status | Pending | ⇒ | Ready to Commit |
RTC
Thanks @infograf768
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13326.
| Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-22 12:49:12 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
|
||
Merged thanks
I have tested this item✅ successfully on d0010c0
works as described
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13326.