[#13325] - File extensions are not uninstalling correctly on package install rollback
- Closed
- 24 Dec 2016
- Medium
- Build: staging
- # 13325
- Diff
- andrepereiradasilva:patch-19
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for New Issue.
Summary of Changes
The file installer adapter is not working correct when a install error exists and the system needs to rollback the changes.
This PR intends to fix that.
Testing Instructions
I don't have an example of a package with a file extension inside,but the issue is the same as #13324
So...
Use latest staging and a package with a file extension + other extensions and make one of the extensions (other than the file extension) fail on install (unzip, add <folder>whatever</folder> to a extension manifest to produce an error and zip again)
-
Reproduce the issue
- Install the corrupted package you will get and error and install of the package should rollback
- Check extensions manage, order by id, and check you have the file extension installed
-
Test patch: Apply patch, install the package and you will see the file extension is now uninstalled correctly on rollback
Documentation Changes Required
None
More info
You can see in the other extension adapters that the var name shoudl be called id, not extension_id, exmaple for plugins and libraries.
Also that is the id that is checked in the installer abort method
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Milestone |
Added: |
||
@andrepereiradasilva he/she spamms i have removed the comment.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13325.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-24 18:34:51 |
| Closed_By | ⇒ | andrepereiradasilva | |
| Labels |
Added:
?
|
||
| Milestone |
Removed: |
||
@alkarana didn't understand