[#13324] - Module extensions are not uninstalling correctly on package install rollback
- Closed
- 24 Dec 2016
- Medium
- Build: staging
- # 13324
- Diff
- andrepereiradasilva:patch-5
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for New Issue.
Summary of Changes
The module installer adapter is not working correct when a install error exists and the system needs to rollback the changes.
This PR intends to fix that.
Testing Instructions
Use latest staging and use this already made pkg_weblinks.zip corrupted test package (just added <folder>whatever</folder> to plg_finder_weblinks manifest to produce an error)
-
Reproduce the issue
- Install the corrupted package you will get and error and install of the package should rollback
- Check extensions manage, order by id, and check you have the module installed
-
Test patch: Apply patch, install the package and you will see the module is now uninstalled correctly on rollback
Documentation Changes Required
None
More info
You can see in the other extension adapters that the var name shoudl be called id, not extension_id, exmaple for plugins and libraries.
Also that is the id that is checked in the installer abort method
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-24 18:34:45 |
| Closed_By | ⇒ | andrepereiradasilva |
| Milestone |
Removed: |
||
I have tested this item✅ successfully on ec46eea
? +1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13324.