The new Permission Label and tip are very unclear.
Edit Value
Allows users in the group to edit any value of an item in any extension.
and
Allows users in the group to edit any value of an item they submitted in this extension.
Basically, except for people who are aware of the development of com_fields, it is impossible to even guess what this permission is about.
Labels |
Added:
?
|
i guess these need to include the term "custom fields"
Just thinking loud. Perhaps in the future other extensions are going to use that permission for other use cases as well?
I think simply saying "custom field" instead of "field" is enough to clarify and it's consistent with the other core labels. I'll look at it right now and start a PR.
Please check PR
See comments there.
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-23 10:26:10 |
Closed_By | ⇒ | infograf768 |
Status | Closed | ⇒ | New |
Closed_Date | 2016-12-23 10:26:10 | ⇒ | |
Closed_By | infograf768 | ⇒ |
I suggest to change in en-GB.ini
JACTION_EDITVALUE="Edit Value"
to
JACTION_EDITVALUE="Edit Custom Fields Value"
and
JACTION_EDITVALUE_COMPONENT_DESC="Allows users in the group to edit any value of the item they submitted in this extension."
to
JACTION_EDITVALUE_COMPONENT_DESC="Allows users in the group to edit any custom field value of the item they submitted in this extension."
Which would give
and in en-GB.com_config.ini
COM_CONFIG_ACTION_EDITVALUE_DESC="Allows users in the group to edit any value of an item in any extension."
to
COM_CONFIG_ACTION_EDITVALUE_DESC="Allows users in the group to edit any custom field value of an item in any extension."
which would give
I found a few custom field specific language strings that need adjustment in the integration options, I'll be working on all of it this weekend.
It is possible to remove [com_fields] from the title of this thread since the issue in question applies to en-GB.ini and will affect many other components? It's a little confusing.
The permission in question was added with com_fields, that's why it has this title.
I understand, but the proposed fix will change the value in other components as well as here because it's a global string.
Is there a way to override the global language strings for the permissions tab on a per component basis?
It works as an override if I put the global string in the com_fields language file, like so:
JACTION_EDITVALUE="Edit Custom Field Value"
It works but it doesn't seem like an ideal solution. It could be confusing or cause issues during translation. Is there a better way to isolate the custom field labels?
The permission shows up in component options, An override in com_fields wouldn't touch those, just the ones in field groups and fields. Imho it is better if they all are the same to avoid confusion.
Thus I'm not a fan of an override, better change the global string. Even if it means adding "Custom Fields" there.
I agree, I'm just trying to figure out the best way to do this.
So, if we change the label string in en-GB.ini it works
But it also affects a few other places so I'm not sure this is the best way to do it either. Contacts and Users will also inherit the text, like so, which could create confusion in those components
The strings are only used in a handful of files, we could easily create specific strings for each component or just for custom fields. Any thoughts on which approach is the best?
Actually, I just realized this is a new string to 3.7. I understanding correctly that this particular string is only used for Custom Fields?
If so, my apologies for all the questions. Just want to make sure I'm thoroughly investigating the options and impact of the suggested changes :)
Actually, I just realized this is a new string to 3.7. I understanding correctly that this particular string is only used for Custom Fields?
Yep, it has been introduced for Custom Fields and currently is only used for that.
Thanks, check out the new PR.
Apologies for the confusion, I've had my head stuck in 3.7 for so long I didn't realize this was completely new. Thanks for your patience :)
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-27 19:09:21 |
Closed_By | ⇒ | Bakual |
Closing this issue as we have a PR
you only need to include the term custom field from my piont of view.
ok sure thanks for telling.
@brianteeman Can u help me i have one question?
Agreed that this needs to be improved.
The idea of this permission is so you can allow certain groups to edit values of custom fields (can be set per field and group), but not allow them to edit the field itself.