?
avatar infograf768
infograf768
22 Dec 2016

The new Permission Label and tip are very unclear.
Edit Value
Allows users in the group to edit any value of an item in any extension.
and
Allows users in the group to edit any value of an item they submitted in this extension.

Basically, except for people who are aware of the development of com_fields, it is impossible to even guess what this permission is about.

@laoneo @Bakual

avatar infograf768 infograf768 - open - 22 Dec 2016
avatar joomla-cms-bot joomla-cms-bot - change - 22 Dec 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 22 Dec 2016
avatar Bakual
Bakual - comment - 22 Dec 2016

Agreed that this needs to be improved.
The idea of this permission is so you can allow certain groups to edit values of custom fields (can be set per field and group), but not allow them to edit the field itself.

avatar infograf768
infograf768 - comment - 22 Dec 2016

i guess these need to include the term "custom fields"

avatar laoneo
laoneo - comment - 22 Dec 2016

Just thinking loud. Perhaps in the future other extensions are going to use that permission for other use cases as well?

avatar cpfeifer
cpfeifer - comment - 22 Dec 2016

I think simply saying "custom field" instead of "field" is enough to clarify and it's consistent with the other core labels. I'll look at it right now and start a PR.

avatar cpfeifer
cpfeifer - comment - 22 Dec 2016

Please check PR

avatar infograf768
infograf768 - comment - 23 Dec 2016

See comments there.

avatar laoneo
laoneo - comment - 23 Dec 2016

Can we close this one as debate is fully going on #13336.

avatar infograf768 infograf768 - change - 23 Dec 2016
Status New Closed
Closed_Date 0000-00-00 00:00:00 2016-12-23 10:26:10
Closed_By infograf768
avatar infograf768 infograf768 - close - 23 Dec 2016
avatar Bakual Bakual - change - 24 Dec 2016
Status Closed New
Closed_Date 2016-12-23 10:26:10
Closed_By infograf768
avatar Bakual Bakual - reopen - 24 Dec 2016
avatar infograf768
infograf768 - comment - 24 Dec 2016

I suggest to change in en-GB.ini
JACTION_EDITVALUE="Edit Value"
to
JACTION_EDITVALUE="Edit Custom Fields Value"
and
JACTION_EDITVALUE_COMPONENT_DESC="Allows users in the group to edit any value of the item they submitted in this extension."
to
JACTION_EDITVALUE_COMPONENT_DESC="Allows users in the group to edit any custom field value of the item they submitted in this extension."
Which would give

screen shot 2016-12-23 at 08 22 29

and in en-GB.com_config.ini
COM_CONFIG_ACTION_EDITVALUE_DESC="Allows users in the group to edit any value of an item in any extension."
to
COM_CONFIG_ACTION_EDITVALUE_DESC="Allows users in the group to edit any custom field value of an item in any extension."
which would give

screen shot 2016-12-23 at 08 25 55

avatar dparul
dparul - comment - 24 Dec 2016

you only need to include the term custom field from my piont of view.

avatar cpfeifer
cpfeifer - comment - 24 Dec 2016

I found a few custom field specific language strings that need adjustment in the integration options, I'll be working on all of it this weekend.

It is possible to remove [com_fields] from the title of this thread since the issue in question applies to en-GB.ini and will affect many other components? It's a little confusing.

avatar Bakual
Bakual - comment - 24 Dec 2016

The permission in question was added with com_fields, that's why it has this title.

avatar cpfeifer
cpfeifer - comment - 27 Dec 2016

I understand, but the proposed fix will change the value in other components as well as here because it's a global string.

Is there a way to override the global language strings for the permissions tab on a per component basis?

avatar cpfeifer
cpfeifer - comment - 27 Dec 2016

It works as an override if I put the global string in the com_fields language file, like so:

JACTION_EDITVALUE="Edit Custom Field Value"

It works but it doesn't seem like an ideal solution. It could be confusing or cause issues during translation. Is there a better way to isolate the custom field labels?

avatar Bakual
Bakual - comment - 27 Dec 2016

The permission shows up in component options, An override in com_fields wouldn't touch those, just the ones in field groups and fields. Imho it is better if they all are the same to avoid confusion.
Thus I'm not a fan of an override, better change the global string. Even if it means adding "Custom Fields" there.

avatar cpfeifer
cpfeifer - comment - 27 Dec 2016

I agree, I'm just trying to figure out the best way to do this.

So, if we change the label string in en-GB.ini it works
field-label-cf

But it also affects a few other places so I'm not sure this is the best way to do it either. Contacts and Users will also inherit the text, like so, which could create confusion in those components
cf-label-users

The strings are only used in a handful of files, we could easily create specific strings for each component or just for custom fields. Any thoughts on which approach is the best?

avatar cpfeifer
cpfeifer - comment - 27 Dec 2016

Actually, I just realized this is a new string to 3.7. I understanding correctly that this particular string is only used for Custom Fields?

If so, my apologies for all the questions. Just want to make sure I'm thoroughly investigating the options and impact of the suggested changes :)

avatar Bakual
Bakual - comment - 27 Dec 2016

Actually, I just realized this is a new string to 3.7. I understanding correctly that this particular string is only used for Custom Fields?

Yep, it has been introduced for Custom Fields and currently is only used for that.

avatar cpfeifer
cpfeifer - comment - 27 Dec 2016

Thanks, check out the new PR.

Apologies for the confusion, I've had my head stuck in 3.7 for so long I didn't realize this was completely new. Thanks for your patience :)

avatar Bakual Bakual - change - 27 Dec 2016
Status New Closed
Closed_Date 0000-00-00 00:00:00 2016-12-27 19:09:21
Closed_By Bakual
avatar Bakual Bakual - close - 27 Dec 2016
avatar Bakual
Bakual - comment - 27 Dec 2016

Closing this issue as we have a PR

avatar dparul
dparul - comment - 1 Jun 2017

you only need to include the term custom field from my piont of view.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13327.

avatar brianteeman
brianteeman - comment - 1 Jun 2017

@dparul please do not comment on a closed issue - no one will see it. If you want to raise an issue please create a new one and reference this if it is relevant

avatar dparul
dparul - comment - 1 Jun 2017

ok sure thanks for telling.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13327.

avatar dparul
dparul - comment - 9 Jun 2017

@brianteeman Can u help me i have one question?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13327.

avatar Bakual
Bakual - comment - 9 Jun 2017

@dparul Please stop posting hidden links in your comments. I've reported you for this behavior.

Add a Comment

Login with GitHub to post a comment