Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#13175] - [com_fields] Change extension variable to context for custom field groups

? Success

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
13 Dec 2016

Summary of Changes

The new field groups (#13019) are created globally per component. It means when a component has more than one context, it is not possible to create groups per context. This pr solves that and allows to create groups per context of fields. A field belongs to a context and with this pr the group as well.

It fixes also an issue where a second asset per group is created when a permission has changed.

Testing Instructions

After a fresh installation, create groups, assign fields to them. All should work as before.

A fresh installation is needed as the database schema has changed..

avatar laoneo laoneo - open - 13 Dec 2016
avatar laoneo laoneo - change - 13 Dec 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Dec 2016
Category ⇒ SQL Administration com_admin Postgresql com_contact com_content com_fields com_users Modules Installation JavaScript
avatar laoneo laoneo - change - 13 Dec 2016
Labels Added: ?
avatar Bakual
Bakual - comment - 13 Dec 2016

Some background to explain why I chose "extension" instead of "context" for the groups:

  • com_categories basically does the same thing and uses "&extension" as the URL parameter to determine the category context. So I just kept the "standard".
  • "context" is already used in JModelList as a class proeprty ($this->context). There is some chance for confusion if there is an additional context which doesn't relate to the model context.

So imho we should change all "context" to "extension" but Allon disagrees with me here ?

avatar ralain
ralain - comment - 14 Dec 2016

I have tested this item ✅ successfully on 8a7f5b0

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13175.

avatar ralain ralain - test_item - 14 Dec 2016 - Tested successfully
avatar anibalsanchez
anibalsanchez - comment - 18 Dec 2016

I have tested this item ✅ successfully on 8a7f5b0

Test OK.

Amazing progress!

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13175.

avatar anibalsanchez anibalsanchez - test_item - 18 Dec 2016 - Tested successfully
avatar jeckodevelopment jeckodevelopment - change - 18 Dec 2016
Status Pending ⇒ Ready to Commit
avatar jeckodevelopment
jeckodevelopment - comment - 18 Dec 2016

RTC based on 2 successful tests

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13175.

avatar jeckodevelopment jeckodevelopment - change - 18 Dec 2016
Milestone Added:
avatar laoneo
laoneo - comment - 18 Dec 2016

Thanks to the testers!

avatar rdeutz rdeutz - reference | 5610e4e - 18 Dec 16
avatar rdeutz rdeutz - merge - 18 Dec 2016
avatar rdeutz rdeutz - close - 18 Dec 2016
avatar rdeutz rdeutz - merge - 18 Dec 2016
avatar rdeutz rdeutz - close - 18 Dec 2016
avatar rdeutz rdeutz - change - 18 Dec 2016
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-12-18 20:18:01
Closed_By ⇒ rdeutz
Labels Added: ?
avatar laoneo laoneo - head_ref_deleted - 18 Dec 2016
avatar alikon alikon - reference | a3209e5 - 19 Dec 16
avatar alikon alikon - reference | aa015c0 - 19 Dec 16
avatar cpfeifer cpfeifer - reference | fb3e6ba - 22 Dec 16

Add a Comment

Login with GitHub to post a comment