? Success

User tests: Successful: Unsuccessful:

avatar marcochirienti
marcochirienti
13 Dec 2016

Summary of Changes

Removed unnecessary spaces after PHP code opening tag.
Removed unnecessary spaces before PHP code closing tag.
Added a white-space before PHP code closing tag where missing.
Fixed style for control structures alternative syntax.
Added a semicolon at the end of statement where missing.

Testing Instructions

Code review.

Documentation Changes Required

None.

avatar marcochirienti marcochirienti - open - 13 Dec 2016
avatar marcochirienti marcochirienti - change - 13 Dec 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Dec 2016
Category Layout Modules Front End
avatar marcochirienti marcochirienti - change - 13 Dec 2016
Title
Staging coding style 7
Coding style - PHP code tag and control structures IV
avatar marcochirienti marcochirienti - change - 13 Dec 2016
Title
Staging coding style 7
Coding style - PHP code tag and control structures IV
avatar marcochirienti marcochirienti - edited - 13 Dec 2016
avatar rdeutz rdeutz - alter_testresult - 13 Dec 2016 - rdeutz: Tested successfully
avatar rdeutz
rdeutz - comment - 13 Dec 2016

code review, ok


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13176.

avatar C-Lodder
C-Lodder - comment - 13 Dec 2016

I have tested this item successfully on 445c5ec

based on code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13176.

avatar C-Lodder C-Lodder - test_item - 13 Dec 2016 - Tested successfully
avatar jeckodevelopment jeckodevelopment - change - 13 Dec 2016
Status Pending Ready to Commit
avatar jeckodevelopment
jeckodevelopment - comment - 13 Dec 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13176.

avatar jeckodevelopment jeckodevelopment - change - 13 Dec 2016
Milestone Added:
avatar rdeutz rdeutz - reference | 64236fd - 14 Dec 16
avatar rdeutz rdeutz - merge - 14 Dec 2016
avatar rdeutz rdeutz - close - 14 Dec 2016
avatar rdeutz rdeutz - change - 14 Dec 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-12-14 20:10:38
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 14 Dec 2016
avatar rdeutz rdeutz - merge - 14 Dec 2016
avatar marcochirienti marcochirienti - head_ref_deleted - 14 Dec 2016
avatar cpfeifer cpfeifer - reference | fb3e6ba - 22 Dec 16

Add a Comment

Login with GitHub to post a comment