[#13170] - Variable names - naming conventions - testing the waters
- Fixed in Code Base
- 18 Dec 2016
- Medium
- Build: staging
- # 13170
- Diff
- frankmayer:naming-conventions-1
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
I was thinking of doing some work on updating variable names according to naming conventions.
Since these are all in function scope, no issues are expected.
Here is a small commit to test the waters with the team. If the things changed in this one commit are ok with you guys, I'll happily attach some more to this PR.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_cache com_categories com_config com_contact com_content com_finder |
@andrepereiradasilva I was thinking, in order to not have hundreds of separate PRs (local branches, etc), to separate in the style of /administrator, then /components then /modules, etc...
Looks good to me as well.
General rule of thumb: smaller PRs are easier to review and test and get merged faster. That is especially important when you touch a lot of files/lines as it reduces the chance for accumulating merge conflicts.
@bakual yes, that's clear now ;) ...
I have not found the golden rule, yet, for such mass changes. I think I'll compartmentalize even further though, as /administrator and /libraries/cms might have a lot of changes...
So let's call the changes in this PR final and get it ready to be merged.
I have tested this item
Test OK
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13170.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13170.
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-18 20:21:01 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
cpfeifer
-
I have tested this item✅ successfully on ed949da
Not that i have any say in this, but for me is ok! Code review.
Still, if this accepted, i would advice to make multiple small PR.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13170.