Feeling Lucky
?
[#13171] - Removed some unnecessary strtotime() calls
- Fixed in Code Base
- 12 Dec 2016
- Medium
- Build: staging
- # 13171
- Diff
- frankmayer:unnecessary-strtotime
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
There were some strtotime("now") calls, which were not necessary as date() automatically uses the current timestamp if none is given.
This PR removes those calls.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners |
ggppdk
- comment
- 12 Dec 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13171.
| Status | Pending | ⇒ | Ready to Commit |
jeckodevelopment
- comment
- 12 Dec 2016
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13171.
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-12 20:58:59 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
zero-24
- | Milestone |
Added: |
||
cpfeifer
-
I have tested this item✅ successfully on c3b33e1
Code review.
Also, to ocnfirm, tested both dates and return the same date as described.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13171.