Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#13169] - Speed up hhvm unit tests - disable jit

? Success

User tests: Successful: Unsuccessful:

avatar csthomas
csthomas
12 Dec 2016

Pull Request for Issue #13168.

Summary of Changes

Turn off the JIT in hhvm to speed up the unit tests.

Source: facebook/hhvm#6979

Testing Instructions

Travis.
Code review.

Documentation Changes Required

N/A

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
5.00
avatar csthomas csthomas - open - 12 Dec 2016
avatar csthomas csthomas - change - 12 Dec 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Dec 2016
Category ⇒ Repository
avatar csthomas csthomas - change - 12 Dec 2016
The description was changed
avatar csthomas csthomas - edited - 12 Dec 2016
avatar PhilETaylor
PhilETaylor - comment - 12 Dec 2016

As JIT is the future (PHP7.1) is this not the wrong thing to do? or am I missing something?

avatar csthomas
csthomas - comment - 12 Dec 2016

I have disabled JIT only for unit tests on travis and only for HHVM.
For production environment JIT is good.

avatar photodude
photodude - comment - 12 Dec 2016

@PhilETaylor I believe the php jit is slated for php8. We likely will end up disabling any jit in php for shot lived things like unit tests since the compiling penalty out weighs the short term benefits. (See the justification link in the pr description)

avatar photodude
photodude - comment - 12 Dec 2016

Wow that's an impressive speed up of nearly 3 minutes. Although I think jit testing has a place, I think that place is in full system tests (alpha, beta, RC, etc) and not in unit tests.

Looks good to me by code review

avatar andrepereiradasilva
andrepereiradasilva - comment - 12 Dec 2016

I have tested this item ✅ successfully on 36131b0

Nice! code review

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13169.

avatar andrepereiradasilva andrepereiradasilva - test_item - 12 Dec 2016 - Tested successfully
avatar photodude
photodude - comment - 12 Dec 2016

I have tested this item ✅ successfully on 36131b0

Looks good, by code review

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13169.

avatar photodude photodude - test_item - 12 Dec 2016 - Tested successfully
avatar jeckodevelopment jeckodevelopment - change - 12 Dec 2016
Status Pending ⇒ Ready to Commit
avatar jeckodevelopment
jeckodevelopment - comment - 12 Dec 2016

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13169.

avatar jeckodevelopment jeckodevelopment - change - 12 Dec 2016
Milestone Added:
avatar rdeutz rdeutz - reference | 9fe43d3 - 13 Dec 16
avatar rdeutz rdeutz - merge - 13 Dec 2016
avatar rdeutz rdeutz - close - 13 Dec 2016
avatar rdeutz rdeutz - change - 13 Dec 2016
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-12-13 12:24:38
Closed_By ⇒ rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 13 Dec 2016
avatar rdeutz rdeutz - merge - 13 Dec 2016
avatar csthomas csthomas - head_ref_deleted - 13 Dec 2016
avatar cpfeifer cpfeifer - reference | fb3e6ba - 22 Dec 16

Add a Comment

Login with GitHub to post a comment