? Pending

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
26 Nov 2016

PR for issue #13032

Summary of Changes

As detected in #13032 there are some issues with the asset_id db columns.
This PR normalizes them.

Testing Instructions

  • On update

    • Run the update queries for your db system manually and check all fine
  • On install

    • Use latest staging, apply patch
    • Delete configuration.php file and install as usual. Check all fine and the db fields are correctly created.

Documentation Changes Required

None.

Notes

Although the issue was found on 4.0 because of a more strict sql_mode, this also applies in 3.x since this db field should always have a default value.

avatar andrepereiradasilva andrepereiradasilva - open - 26 Nov 2016
avatar andrepereiradasilva andrepereiradasilva - change - 26 Nov 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Nov 2016
Category SQL Administration com_admin Postgresql MS SQL Installation
avatar andrepereiradasilva andrepereiradasilva - change - 26 Nov 2016
Title
[asset_id dbfield] add alwyas defaul and normalise across db systems
[asset_id db field] add default value and normalise across db systems
avatar andrepereiradasilva andrepereiradasilva - edited - 26 Nov 2016
avatar andrepereiradasilva andrepereiradasilva - change - 26 Nov 2016
Title
[asset_id dbfield] add alwyas defaul and normalise across db systems
[asset_id db field] add default value and normalise across db systems
avatar andrepereiradasilva
andrepereiradasilva - comment - 26 Nov 2016

@alikon please review/test

8a9653f 26 Nov 2016 avatar andrepereiradasilva ups
avatar andrepereiradasilva andrepereiradasilva - change - 26 Nov 2016
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - change - 26 Nov 2016
The description was changed
Labels Removed: ?
avatar andrepereiradasilva andrepereiradasilva - edited - 26 Nov 2016
avatar andrepereiradasilva andrepereiradasilva - change - 2 Jan 2017
Labels Added: ?
avatar alikon
alikon - comment - 10 Jan 2017

I have tested this item successfully on 379031a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13034.

avatar alikon alikon - test_item - 10 Jan 2017 - Tested successfully
avatar csthomas
csthomas - comment - 24 Jan 2017

Please resolve the conflict.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 28 May 2017

If this PR get no Response, it will be closed at 22th June 2017.

avatar franz-wohlkoenig franz-wohlkoenig - change - 22 Jun 2017
Status Pending Closed - No Reply
Closed_Date 0000-00-00 00:00:00 2017-06-22 06:41:48
Closed_By franz-wohlkoenig
avatar joomla-cms-bot
joomla-cms-bot - comment - 22 Jun 2017
avatar joomla-cms-bot joomla-cms-bot - edited - 22 Jun 2017
avatar joomla-cms-bot joomla-cms-bot - close - 22 Jun 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 22 Jun 2017

closed as stated above.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13034.

Add a Comment

Login with GitHub to post a comment