? ? Success

User tests: Successful: Unsuccessful:

avatar jeckodevelopment
jeckodevelopment
26 Nov 2016

Summary of Changes

Links to the Joomla! Resources Directory now use HTTPS.
Changed both readme files of the repo and the links in the administration menu, also for Hathor template.

Testing Instructions

Code review + test admin links to JRD

Documentation Changes Required

None.

avatar jeckodevelopment jeckodevelopment - open - 26 Nov 2016
avatar jeckodevelopment jeckodevelopment - change - 26 Nov 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Nov 2016
Category Repository Modules Administration Templates (admin)
avatar andrepereiradasilva
andrepereiradasilva - comment - 26 Nov 2016

there qare move files with that url

egrep -R "resources\.joomla\.org" /path/to/joomla-staging/

/README.md:
/administrator/templates/hathor/html/mod_menu/default_enabled.php
/administrator/modules/mod_menu/tmpl/default_enabled.php
/README.txt
/tests/unit/stubs/database/jos_ucm_content.csv
/tests/unit/stubs/database/jos_content.csv
/tests/unit/stubs/database/jos_finder_links.csv
/installation/sql/mysql/sample_testing.sql
/installation/sql/mysql/sample_learn.sql
/installation/sql/postgresql/sample_testing.sql
/installation/sql/postgresql/sample_learn.sql
/installation/sql/sqlazure/sample_testing.sql
/installation/sql/sqlazure/sample_learn.sql
avatar jeckodevelopment
jeckodevelopment - comment - 26 Nov 2016

@andrepereiradasilva thanks. Will look at them :)

avatar jeckodevelopment jeckodevelopment - change - 26 Nov 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 26 Nov 2016
Category Repository Modules Administration Templates (admin) Repository Modules Administration Templates (admin) Unit Tests
avatar jeckodevelopment jeckodevelopment - change - 26 Nov 2016
Labels Added: ?
avatar jeckodevelopment jeckodevelopment - change - 26 Nov 2016
Labels Removed: ?
avatar jeckodevelopment jeckodevelopment - change - 26 Nov 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 26 Nov 2016
Category Repository Modules Administration Templates (admin) Unit Tests Repository Modules Administration Templates (admin) SQL Installation Unit Tests
avatar jeckodevelopment jeckodevelopment - change - 26 Nov 2016
Labels Removed: ?
avatar jeckodevelopment jeckodevelopment - change - 26 Nov 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 26 Nov 2016
Category Repository Modules Administration Templates (admin) Unit Tests SQL Installation Repository Modules Administration Templates (admin) SQL Installation Postgresql Unit Tests
avatar jeckodevelopment jeckodevelopment - change - 26 Nov 2016
Labels Removed: ?
avatar jeckodevelopment jeckodevelopment - change - 26 Nov 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 26 Nov 2016
Category Repository Modules Administration Templates (admin) Unit Tests SQL Installation Postgresql Repository Modules Administration Templates (admin) SQL Installation Postgresql MS SQL Unit Tests
avatar jeckodevelopment jeckodevelopment - change - 26 Nov 2016
Labels Removed: ?
avatar jeckodevelopment
jeckodevelopment - comment - 26 Nov 2016

@andrepereiradasilva it should be ok now :)

avatar andrepereiradasilva
andrepereiradasilva - comment - 26 Nov 2016

@jeckodevelopment see jeckodevelopment#1 for missing changes

avatar jeckodevelopment
jeckodevelopment - comment - 26 Nov 2016

Done, thanks!

avatar andrepereiradasilva
andrepereiradasilva - comment - 26 Nov 2016

I have tested this item successfully on 004e247

code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13033.

avatar andrepereiradasilva andrepereiradasilva - test_item - 26 Nov 2016 - Tested successfully
avatar yvesh
yvesh - comment - 26 Nov 2016

I have tested this item successfully on 004e247

code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13033.

avatar yvesh yvesh - test_item - 26 Nov 2016 - Tested successfully
avatar mbabker
mbabker - comment - 26 Nov 2016

JRD neither forces HTTPS and still has mixed content warnings.

avatar andrepereiradasilva
andrepereiradasilva - comment - 26 Nov 2016

ok, i assumed those issues were already resolved because @jeckodevelopment was making a PR.

ok so first those issues need to be solved and only them this PR should be merged

avatar brianteeman
brianteeman - comment - 30 Nov 2016

I am closing this for now - it can be reopened (if still mergeable) when the JRD finally understands mixed content


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13033.

avatar brianteeman brianteeman - change - 30 Nov 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-11-30 19:51:35
Closed_By brianteeman
avatar brianteeman brianteeman - close - 30 Nov 2016
avatar brianteeman brianteeman - close - 30 Nov 2016

Add a Comment

Login with GitHub to post a comment