Feeling Lucky
?
[#13035] - [modules db table] Add default to content db field in mysql (already like that is postgresql and sqlsrv)
- Fixed in Code Base
- 6 Dec 2016
- Medium
- Build: staging
- # 13035
- Diff
- andrepereiradasilva:modules-default-content
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Add empty default value to #__modules content db field in mysql (already like that is postgresql and sqlsrv).
Testing Instructions
Mainly code review. But you can also:
-
On update
- Run the update query for your db system manually and check the db field now as a default value.
-
On install
- Use latest staging, apply patch
- Delete configuration.php file and install as usual. Check all fine and the db field are correctly created.
Documentation Changes Required
None.
Notes
Although the issue was found on 4.0 because of a more strict sql_mode, this also applies in 3.x since this db field should always have a default value.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Administration com_admin Installation |
| Title |
|
||||||
| Title |
|
||||||
| Labels |
Added:
?
|
||
alikon
- comment
- 26 Nov 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13035.
jeckodevelopment
- comment
- 26 Nov 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13035.
| Status | Pending | ⇒ | Ready to Commit |
jeckodevelopment
- comment
- 26 Nov 2016
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13035.
| Milestone |
Added: |
||
wilsonge
- comment
- 29 Nov 2016
What is this field used for? If it's not used I'd rather remove it in postgres and mssql than keep junk
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-06 22:27:19 |
| Closed_By | ⇒ | rdeutz |
I have tested this item✅ successfully on 5e2d504
code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13035.