? ? Success

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
22 Nov 2016

One of our translators raised an issue on Crowdin regarding the source strings in the Google Authenticator Two Factor Authentication plugin.

Summary of Changes

  • Removes a duplicated "Google Authenticator"
  • Removes a space in an anchor tag before "FreeOTP" googletotp

Testing Instructions

Check the plugin description and see that it is correct now.

Documentation Changes Required

None

avatar Bakual Bakual - open - 22 Nov 2016
avatar Bakual Bakual - change - 22 Nov 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Nov 2016
Category Administration Language & Strings
avatar brianteeman
brianteeman - comment - 22 Nov 2016

Something went wrong somewhere. It was supposed to be a link to the
Wikipedia page iirc

On 22 Nov 2016 7:32 p.m., "Thomas Hunziker" notifications@github.com
wrote:

One of our translators raised an issue on Crowdin regarding the source
strings in the Google Authenticator Two Factor Authentication plugin.
Summary of Changes

Testing Instructions

Check the plugin description and see that it is correct now.
Documentation Changes Required

None

You can view, comment on, or merge this pull request online at:

#12980
Commit Summary

  • Remove duplicate "Google Authenticator" and a space within an anchor tag.

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#12980, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8bONYeDQ5YCbV3374nozSph34EcLks5rA0NXgaJpZM4K52Ro
.

avatar andrepereiradasilva
andrepereiradasilva - comment - 22 Nov 2016

I have tested this item successfully on 0eed57f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12980.

avatar andrepereiradasilva andrepereiradasilva - test_item - 22 Nov 2016 - Tested successfully
avatar Bakual
Bakual - comment - 22 Nov 2016

Something went wrong somewhere.

@brianteeman Looks certainly like something went wrong ?
PR that introduced it is indeed from you: #12833
Should be correct now, right?

avatar jeckodevelopment
jeckodevelopment - comment - 22 Nov 2016

I have tested this item successfully on 0eed57f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12980.

avatar jeckodevelopment jeckodevelopment - test_item - 22 Nov 2016 - Tested successfully
avatar jeckodevelopment jeckodevelopment - change - 22 Nov 2016
Status Pending Ready to Commit
Labels
avatar jeckodevelopment
jeckodevelopment - comment - 22 Nov 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12980.

avatar jeckodevelopment jeckodevelopment - change - 22 Nov 2016
Labels Added: ?
avatar jeckodevelopment jeckodevelopment - change - 22 Nov 2016
Milestone Added:
avatar brianteeman
brianteeman - comment - 22 Nov 2016

I would prefer it if we were consistent and either made Google and freeotp links in the first string or neither of them

avatar Bakual
Bakual - comment - 22 Nov 2016

You mean in the other string (PLG_TWOFACTORAUTH_TOTP_STEP1_TEXT)? In the description I left the link and deleted the superfluous "Google Authenticator" after the link. So that should be fine now.

avatar brianteeman
brianteeman - comment - 22 Nov 2016

I mean there is only a link to freeotp in that string . The others have a link to Google authenticator as well. It was the failure to paste the link correctly in the first place by me that gave the double text

avatar Bakual
Bakual - comment - 23 Nov 2016

Ah I see. Added the link there as well.

avatar brianteeman
brianteeman - comment - 23 Nov 2016

Thanks

avatar wilsonge wilsonge - change - 24 Nov 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-11-24 09:14:55
Closed_By wilsonge
avatar wilsonge wilsonge - close - 24 Nov 2016
avatar wilsonge wilsonge - merge - 24 Nov 2016
avatar wilsonge wilsonge - reference | 81142af - 24 Nov 16
avatar wilsonge wilsonge - merge - 24 Nov 2016
avatar wilsonge wilsonge - close - 24 Nov 2016

Add a Comment

Login with GitHub to post a comment