[#12979] - [com_tags] review config global default options
- Closed
- 23 Sep 2018
- Medium
- Build: staging
- # 12979
- Diff
- andrepereiradasilva:patch-35
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
User tests: Successful: Unsuccessful:
Summary of Changes
This PR intends to normalize config global default options in com_tags.
The method used was:
- Review cs of the config.xml file - also add missing default values
- Check the current params in installation joomla.sql mysql
- Add missing defaults to install sql
Testing Instructions
- Code review
- Apply patch
- Delete configuration.php
- Install Joomla (no sample)
- Create tag menu items and check all "Use Global" have the global value.
Documentation Changes Required
None.
Added/changed defaults in the xml
changed:
- history_limit: 10 (was 5 - uniformize with articles)
- tag_list_orderby: c.core_title (was
title- which doesn't exist)
added:
- tag_list_image: empty
- tag_list_show_item_description: 1 (the first option of the list)
- tag_list_item_maximum_characters: 0 (not sure about this one please confirm)
- all_tags_tag_maximum_characters: 0 (not sure about this one please confirm)
Note: also correct the parameter all_tags_show_tag_descripion by all_tags_show_tag_description this was nto working because the parameter was badly named in the xml files
| Status | New | ⇒ | Pending |
| Category | ⇒ | com_tags Administration SQL Installation Postgresql MS SQL |
On a current clean install the values are tag_list_show_item_description: 0 - even though the default in the xml is 1 - not sure if there is a b/c issue with changing it
installation can have diferent values than the default in xml. AFAIK there is no B/C issue with that.
Anyway i didn't change that in the installation.
Also you can see that in the php the default is 1 https://github.com/joomla/joomla-cms/blob/staging/components/com_tags/views/tag/tmpl/default_items.php#L97
I couldnt find tag_list_item_maximum_characters or all_tags_tag_maximum_characters
besides xml and sql:
# egrep -n -R "tag_list_item_maximum_characters" /path/to/joomla-staging/
/path/to/joomla-staging/components/com_tags/views/tag/tmpl/default_items.php:101
/path/to/joomla-staging/components/com_tags/views/tags/tmpl/default_items.php:116
# egrep -n -R "all_tags_tag_maximum_characters" /path/to/joomla-staging/
(none)
I have test #12979 and #12981
Menu Item: Compact list of tagged items
Does not show the Global setting for:
Items to List (Tab List Layouts)
The other two menu items are OK:
Tagged Items
List of all tags
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12979.
If this Issue get no Response, it will be closed at 22th September 2018.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-09-23 05:17:33 |
| Closed_By | ⇒ | franz-wohlkoenig |
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/12979
This has been closed due to lack of response to the requests above – it can always be reopened.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12979.
On a current clean install the values are
tag_list_show_item_description: 0 - even though the default in the xml is 1 - not sure if there is a b/c issue with changing it
I couldnt find tag_list_item_maximum_characters or all_tags_tag_maximum_characters
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12979.