[#12981] - [com_tags] tags menu items parameters review
- Closed
- 23 Sep 2018
- Medium
- Build: staging
- # 12981
- Diff
- andrepereiradasilva:tags-menu-items
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 0 Successful 1 Failed. Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
User tests: Successful: Unsuccessful:
Summary of Changes
While making the PR to check the global default options i noticed some issues with the menu items.
So this PR does for the 3 com_tags menu items a review:
- XML Code Style
- Remove all default values of parameters that use useglobal (otherwise this would override the useglobal)
- Remove all filter="integer" values of parameters that use useglobal (otherwise this would tur the empty value to 0 when saving and thus messing the useglobal logic)
- Added some deprecated and todo paramaters to the parameter that does not use useglobal
Testing Instructions
- XML code review (use https://github.com/joomla/joomla-cms/pull/12981/files?w=1 for ignoring the whitespace changes - faster)
- Apply patch and #12979 patch (if not merged)
- Go to com_tags options and save the options
- Create the 3 tag menu items type and global values are there
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
| Category | ⇒ | com_tags Front End |
| Labels |
Added:
?
|
||
Still got some show global without the values
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12981.
Ooops posted on the wrong item - i havent tested this one yet
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12981.
I have tested this item
Missing Information about "Global Setting" in Compact list of tagged itemson Tab List Layouts the # Items to List. Other 2 menu item types shows Value of Global Setting.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12981.
If this Issue get no Response, it will be closed at 22th September 2018.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-09-23 05:18:05 |
| Closed_By | ⇒ | franz-wohlkoenig |
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/12981
| Closed_Date | 2018-09-23 05:18:05 | ⇒ | 2018-09-23 05:18:06 |
| Closed_By | franz-wohlkoenig | ⇒ | joomla-cms-bot |
This has been closed due to lack of response to the requests above – it can always be reopened.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12981.
I have tested this item? unsuccessfully on a1981e1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12981.