[#12801] - Updating checkToken usage to utilise the new JControllerLegacy::checkToken
- Fixed in Code Base
- 3 Sep 2018
- Medium
- Build: staging
- # 12801
- Diff
- izharaazmi:checktoken2
- Success Hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Error continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Pull Request in continuation to #8445
Summary of Changes
Implementing the new pattern everywhere. All controllers that extend JControllerLegacy are set to use the "nice" handling instead of white screen on a token validation failure.
Wherever this was within a JSON response, the handling is kept intact as they are better suited it those contexts, changing only the message text.
Testing Instructions
Test the various backend and front-end forms which would earlier show a blank white page with just a message "Invalid Token". They should now redirect to same page if possible otherwise to home page; with appropriate message.
To see the effect the respective forms should be submitted after manipulating the token input in the form so as to trigger invalid token situation. This can usually be done by selecting in the browser "inspect element" (or similar) and modify the DOM.
If the token is valid (not manipulated or expired), everything should be working as usual without any difference.
The affected components are:
- Banners
- Cache
- Categories
- Contacts
- ContentHistory
- CustomFields
- Finder
- Installer
- Joomla Update
- Language Manager
- Login/Logout
- Media Manager
- Module Manager
- Menu Manager
- Tags
- Template Manager
- User Manager
- Joomla Installation Application (
/installation)
Documentation Changes Required
Developer documentation should include this feature introduction. Text can be taken from #8445
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Components com_media |
| Category | Administration Components com_media | ⇒ | Administration com_banners com_cache com_categories com_checkin com_contact com_content com_contenthistory com_fields com_finder com_installer com_joomlaupdate com_languages com_login com_media com_menus Components |
There is something wrong in all merge 'staging' happening these days. Not sure why. Will look again into this later.
I have tested this item
Unable to apply patch via git.
Applying patch with com_patchtester did not resolve the issues.
Tested:
- Banners (New -> Name "test" -> removed last character of token -> Save)
- Categories (New -> Name "test" -> removed last character of token -> Save)
- Module Manager (New -> „Articles - Latest“ -> Title „test“ -> removed last character of token -> Save)
Result:
- Banners: White Error Page
- Categories: White Error Page
- Module Manager: New message (green box)
Result: No change in Banners (admin) und Categories (admin).
@icampus
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12801.
@SamuelSchepp There are conflicts so patchtester/git may not be able to apply patch correctly. I'll resolve the conflicts then please test again.
I have tested this item
I have tested this item succesfully
I changed session lifetime of global configuration to 1 minute
Tested:
Banners (New -> Name "test" -> wait 1 minute -> Save)
Contacts(New -> Name "test" -> wait 1 minute -> Save)
Result:
Banners: redirected sign in page
Contacts: redirected sign in page
@icampus
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12801.
I have tested this item
What I tested:
Banner -> new -> Name "Test" -> Clear Site Data -> Save
Contacts -> new -> Name "Test" -> Clear Site Data -> Save
Joomla! Update -> Choose File -> Clear Site Data -> Upload & Install
Results:
Banner: Redirect to login page, after login redirect to Banner List page
Contacts: Redirect to login page, after login redirect to Contacts List page
Joomla! Update: Redirect to login page, after login redirect to home page
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12801.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
@mbabker Good catch. This is not a new file but a file that was deleted in commit 204ef46 and this PR has not been updated since. So that is why it is still there. So this file should be removed from this PR. Either by @izharaazmi or a maintainer merging this PR.
@izharaazmi can you please remove the File mentioned above by @roland-d and @mbabker?
| Labels |
Added:
?
|
||
| Category | Administration Components com_media com_banners com_cache com_categories com_checkin com_contact com_content com_contenthistory com_fields com_finder com_installer com_joomlaupdate com_languages com_login com_menus | ⇒ | Administration com_associations com_banners com_cache com_categories com_checkin com_contact com_content com_contenthistory com_fields com_finder com_installer com_joomlaupdate com_languages com_login com_media Components |
Done the conflict anomaly fix. I have updated 5 more of those usages. So maintainers might recommend to clear current test status.
PS: Can we have a new Label something like "Needs Work" or "Author Attention" so that it can be found out clearly which PR needs attention?
Label something like "Needs Work" or "Author Attention"
@izharaazmi at Issue Tracker is an "Needs Review"-Status. But this isn't shown here and vice versa (Issue about this is open joomla/jissues#1032).
IMO, "Needs Review" sound more like a Reviewer attention rather than Author attention. Or not?
True. It was an Information about what is available.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-09-03 17:19:36 |
| Closed_By | ⇒ | mbabker |
ok from code review, just added one question, when possible will try to do some tests and see if there is no other left.