? Success

User tests: Successful: Unsuccessful:

avatar AlexRed
AlexRed
7 Nov 2016

Pull Request for Issue #12304 .

Summary of Changes

delete old files in the update procedure

Testing Instructions

install a new 3.2.3 version, update to 3.7.0 and some old files still here:
libraries/joomla/github/users.php
media/system/js/validate-jquery-uncompressed.js
templates/beez3/html/message.php
libraries/fof/platform/joomla.php
libraries/fof/readme.txt

Documentation Changes Required

from an 3.2.3 installation, these file no longer exist in Joomla 3.7.0

avatar AlexRed AlexRed - open - 7 Nov 2016
avatar AlexRed AlexRed - change - 7 Nov 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Nov 2016
Category Administration Components
avatar zero-24 zero-24 - change - 7 Nov 2016
Milestone Added:
avatar zero-24 zero-24 - change - 7 Nov 2016
Labels Added: ?
avatar brianteeman
brianteeman - comment - 10 Nov 2016

Upgraded a site from 3.2.3 and I can confirm that these files should be removed.

I note that they are in the section 3.2 of the uninstall script
Shouldnt they be in a 3.2.3 section


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12802.

avatar brianteeman
brianteeman - comment - 14 Nov 2016

@AlexRed if you can put them in a 3.2.3 section then this can be merged


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12802.

avatar AlexRed
AlexRed - comment - 14 Nov 2016

For me is not correct insert it in a 3.2.3 sub section.
For example the file /libraries/joomla/github/users.php is also in the 3.2.2 version.
I do not understand why you want to acting in this way with my requests, also in the file the list for 3.0 and 3.1 and 3.2 don't have the sub section. But now my PR need the sub section :(
The previous PR #12304 It was boycotted and now this.. but please do not copy it in a your PR please. Let's other people do it.

avatar brianteeman
brianteeman - comment - 14 Nov 2016

If you review the file you will see that we always use the full version that the file was removed in

avatar AlexRed
AlexRed - comment - 14 Nov 2016

no, for files from versions 1.6 - 1.7 - 2.5 - 3.0 -3.1 -3.2 is not.

avatar brianteeman
brianteeman - comment - 14 Nov 2016

yes it was a change. I am not going to argue - not my pr - i dont care if this gets merged or not but if it is to be merged then it should follow our current standards

avatar infograf768
infograf768 - comment - 17 Dec 2016

I have tested this item successfully on cff044b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12802.

avatar infograf768 infograf768 - test_item - 17 Dec 2016 - Tested successfully
avatar stellainformatica
stellainformatica - comment - 17 Dec 2016

I have tested this item successfully on cff044b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12802.

avatar stellainformatica stellainformatica - test_item - 17 Dec 2016 - Tested successfully
avatar infograf768 infograf768 - change - 17 Dec 2016
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 17 Dec 2016

RTC. Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12802.

avatar wilsonge wilsonge - close - 18 Dec 2016
avatar wilsonge wilsonge - merge - 18 Dec 2016
avatar wilsonge wilsonge - reference | 895db8b - 18 Dec 16
avatar wilsonge wilsonge - merge - 18 Dec 2016
avatar wilsonge wilsonge - change - 18 Dec 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-12-18 11:30:05
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 18 Dec 2016
avatar joomla-cms-bot joomla-cms-bot - change - 18 Dec 2016
Category Administration Components Administration com_admin Components

Add a Comment

Login with GitHub to post a comment