[#12800] - [ACL] [com_categories categories view] Correct when display batch button
- Closed
- 15 Nov 2016
- Medium
- Build: staging
- # 12800
- Diff
- andrepereiradasilva:patch-29
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
The categories ACL for displaying the batch button is not correct. It's based on a extension var that is not correct, for instance in com_fields groups the asset name is com_contentarticlefields when it should be com_content.
Testing Instructions
- Code review.
- Test if "Batch" button appears on com_content field groups when a user is not able to
core.create. - Apply patch
- Repeat step 2, no button now
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Components |
PLus the fact that it has been decided that com_field architecture may be changed to not use com_categories anymore...
This is not a com_fields errors, in the core it only manifests in com_fields because it's the only one, for now, that uses component.item format extension.
cando it's used all over this toolbar method and it's using the component acl.
Please test.
Ah I see, you're right
PLus the fact that it has been decided that com_field architecture may be changed to not use com_categories anymore
Is this decision made public somewhere? I would not do that?
please don't turn this PR into a com_fields discussion.
as said, this Pr as nothing to do with com_fields, just only manifests in com_fields because the core doesn't have any other category that uses component.item format extension.
| Title |
|
||||||
| Title |
|
||||||
A lot of PRs lately are missing SHA in the issue tracker, and tests cannot be submitted
I have tested this item
The test instructions not really working for me, the Batch button is not showing before & after when the core.create action is not allowed.
However, I do agree with the code changes and the change of the context into the component.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12800.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12800.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12800.
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-15 21:41:01 |
| Closed_By | ⇒ | rdeutz |
| Category | Administration Components | ⇒ | Administration com_categories Components |
That sounds wrong. com_categories doesn't have own ACL rules. It uses the ones from the extensions.
if you remove that check, it means the global ACL settings will be used instead of the component specific ones.
If that doesn't work for com_fields, it is an issue in com_fields and how it handles its groups. It's not something that has to be changed (and even less removed!) in com_categories.