[#12791] - Fix for Undefined offset in Content History preview popup
- Fixed in Code Base
- 18 Nov 2016
- Medium
- Build: staging
- # 12791
- Diff
- PhilETaylor:staging
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Set error reporting to E_ALL (Like it should be for development)
Article Manager -> Edit Getting Started -> Versions -> Select a version -> popup url is like:
repeated errors on page of
Notice: Undefined offset: 0 in example.com/administrator/components/com_contenthistory/helpers/contenthistory.php on line 123
Summary of Changes
Better checking of the array before attempting to access its members
Testing Instructions
Do above - replicate Notices, apply patch, see they disappear...
Documentation Changes Required
None
EDIT
So like a prat I committed my next fix to this branch too... so this PR now contains that too.
The problem that solves is that if you fake a non-existing version ID in the popup with a url like:
http://127.0.0.1:8000/administrator/index.php?option=com_contenthistory&view=preview&layout=preview&tmpl=component&b05a6963679e395c78f4b883e2c00b56=1&version_id=212312
Then you get
This PR also fixes that now...
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Components |
| Labels |
Added:
?
|
||
| Category | Administration Components | ⇒ | Administration com_content com_contenthistory Components |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12791.
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Labels | |||
| Milestone |
Added: |
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12791.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-18 20:39:18 |
| Closed_By | ⇒ | rdeutz |
make travis happy, travis I hate you, tab/spaces hell
These are all reasons why I'm trying to get a PHPCS2 version of our code standards tested and verified so we have automatic fixers to correct most of the general code style issues.
I have tested this item✅ successfully on 3a466a2
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12791.