[#12790] - Regression 3.7: menu item params loaded incorrectly
- Closed
- 6 Nov 2016
- Medium
- Build: staging
- # 12790
- Diff
- joomla:3.7.x
- Success continuous-integration/travis-ci/push The Travis CI build passed Details
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #12787
Summary of Changes
Issue is due to the change at root/libraries/cms/application/site.php line 355 from:
$temp = new Registry; $temp->loadString($menu->params);
to
$temp = new Registry($menu->params);
Testing Instructions
Test the menu item params override no more taking effect in com_content, etc
Documentation Changes Required
Steps to reproduce the issue
Use JApplicationSite getParams('com_mycomponent') method for a certain component in the frontend, having a valid routed menu item.
Expected result
All component params are merged with the specific menu item parameters in the same JRegistry object
If you have a menu item parameter 'myparam' and you call:
$registry = $this->app->getParams('com_mycomponent') ;
You always had:
$myParam = $registry->get('myparam');
Actual result
Menu item parameters are not merged as properties of the JRegistry object that can be obtained using the JRegistry 'get' method, but instead menu items parameters are all included in an array property named 'data'.
If you have a menu item parameter 'myparam' and you call:
$registry = $this->app->getParams('com_mycomponent') ;
You have:
$menuParameters = $registry->get('data');
$myParam = $menuParameters['myparam'];
System information (as much as possible)
Issue is due to the change at root/libraries/cms/application/site.php line 355 from:
$temp = new Registry; $temp->loadString($menu->params);
to
$temp = new Registry($menu->params);
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) |
What does this have to do with back to top
Nothing, i don't know why it's there.
Perhaps your pr was not made against staging and you merged updates into
your branch
I don't know... however feel free to fix this PR if you know how to do it
We can't fix your PR. Maybe you try it this way: https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests
I see nothing to fix and remove the back to top reference.
We can't fix it this way ;) this is a way to do a PR via the Github GUI and this should not produce broken PRs ;)
Can you open a new PR starting from this one? It would be the same
Nope that would repeat your error
On 6 Nov 2016 7:30 p.m., "JoeforJoomla Boy" notifications@github.com
wrote:
Can you open a new PR starting from this one? It would be the same
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12790 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8fAhkoIOoDSxlRcz4_cqvtx7w3woks5q7irhgaJpZM4KqmJo
.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-06 21:01:28 |
| Closed_By | ⇒ | zero-24 |
This looks broken as this is a commit by @brianteeman ?