User tests: Successful: Unsuccessful:
Pull Request for Issue #12784
Add a new script option for TinyMCE:
$scriptOptions['valid_children'] = '+a[div|p|h1|h2|h3|h4|h5|h6]';
TinyMCE try adding block elements: div or p or h1 inside a link
No code cleanup should happen
None
Status | New | ⇒ | Pending |
Category | ⇒ | Front End Plugins |
Labels |
Added:
?
|
I really feel that this is a bug in tinymce and that you should be raising it there
When we instatiate tinyMCE we are adding appropriate configuration for other options
-- thus we do not use the tinyMCE default configuration for all these other options
The value for this particular configuration option is not desired or not appropriate ?
Should we wait for tinyMCE to update their default configuration ?
-- i am guessing they did not care much, because this is configurable and configuration values have been suggested that work
never guess- if it is a bug in tinymce then I am sure they would
expect/hope you report it to them. We really shouldnt be changing the
behaviour of an external plugin
On 4 December 2016 at 15:52, Georgios Papadakis notifications@github.com
wrote:
When we instatiate tinyMCE we are adding appropriate configuration for
other options
-- thus we do not use the tinyMCE default configuration for all these
other optionsThe value for this particular configuration option is not desired or not
appropriate ?Should we wait for tinyMCE to update their default configuration ?
-- i am guessing they did not care much, because this is configurable and
configuration values have been suggested that work—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12792 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8S2y5cvsnPtD3-PXiHp-DwYRjSIsks5rEtOsgaJpZM4Kqn-g
.
--
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/
@brianteeman
I found their response exactly for this, please read here
tinymce/tinymce#3142
They are worried what the user may nest inside a
and also about nesting links inside a link
I can close this, if you think it creates more problems that it solves
My view is that we should not be changing the behaviour of a plugin. If a user disagrees with that behaviour then they are free to use another editor
I am going to close this as I really think we should not be overriding default behaviour of an external library
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-07 16:05:41 |
Closed_By | ⇒ | brianteeman |
@brianteeman This is an old issue but still relevant do you still hold the same opinion as the TinyMCE plugin also allows to override other settings like valid_ements, extended_valid_elements it would be nice if there was an option to configure valid children to: https://www.tiny.cloud/docs-3x/reference/configuration/Configuration3x@valid_children/
Tiny default is
valid_children:"-li[p]"
I see no reason indeed to not add this as a parameter with -li[p]
as default.
I have tested this item✅ successfully on 620bbfd
Works as described. Block level elements are now preserved inside links.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12792.