Feeling Lucky
?
[#12712] - sql - support for scss,sass source formats
- Fixed in Code Base
- 2 Nov 2016
- Medium
- Build: staging
- # 12712
- Diff
- alikon:patch-87
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | SQL Administration Components Postgresql MS SQL Installation |
| Title |
|
||||||
| Title |
|
||||||
mbabker
- comment
- 2 Nov 2016
This overwrites the entire component parameters. Not sure that's a good idea...
mbabker
- comment
- 2 Nov 2016
If you want to add the values during the update, it can't be a full replacement of the parameters column like it is now. If you choose not to add the values then just removing the update SQLs is fine.
alikon
- comment
- 2 Nov 2016
lets'go only with install for now , the full update of the param field as noticed was a really bad idea
andrepereiradasilva
- comment
- 2 Nov 2016
I have tested this item
on code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12712.
C-Lodder
- comment
- 2 Nov 2016
I have tested this item
I do hope the update side of things isn't forgotten about though
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12712.
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-02 19:21:05 |
| Closed_By | ⇒ | zero-24 |
alikon
- comment
- 2 Nov 2016
i'm thinking something about this update query:
UPDATE params =
replace(params,'"source_formats":"','"source_formats":"scss,sass,')
FROM #__extensions
where extension_id =20;`
what do you think?
zero-24
- comment
- 2 Nov 2016
Thanks!
We need to revert the update part as it would overwrite the current settings by the site owners.