? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
2 Nov 2016

Pull Request for Issue #12711.

Summary of Changes

Following @brianteeman idea this adds the current date (up to minute) as media version for installation.

Testing Instructions

  1. Code review
  2. Go to /installation/index.php?view=languages, view page source and confirm media version DOES NOT EXISTS in js files
  3. Apply patch
  4. Go to /installation/index.php?view=languages, view page source and confirm media version EXISTS js files

Documentation Changes Required

None

avatar andrepereiradasilva andrepereiradasilva - open - 2 Nov 2016
avatar andrepereiradasilva andrepereiradasilva - change - 2 Nov 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Nov 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 2 Nov 2016
Category Installation
avatar andrepereiradasilva andrepereiradasilva - change - 2 Nov 2016
Title
Media Versin on installation Solve 12711
Media Version on installation Solve 12711
avatar andrepereiradasilva andrepereiradasilva - change - 2 Nov 2016
Title
Media Versin on installation Solve 12711
Media Version on installation Solve 12711
avatar andrepereiradasilva andrepereiradasilva - edited - 2 Nov 2016
avatar andrepereiradasilva andrepereiradasilva - change - 2 Nov 2016
The description was changed
avatar andrepereiradasilva andrepereiradasilva - edited - 2 Nov 2016
avatar andrepereiradasilva andrepereiradasilva - change - 2 Nov 2016
Title
Media Version on installation Solve 12711
Media Version on installation (solves 12711)
avatar andrepereiradasilva andrepereiradasilva - change - 2 Nov 2016
Title
Media Version on installation Solve 12711
Media Version on installation (solves 12711)
avatar andrepereiradasilva andrepereiradasilva - edited - 2 Nov 2016
avatar andrepereiradasilva andrepereiradasilva - change - 2 Nov 2016
Title
Media Version on installation (solves 12711)
Media Version on installation (solves #12711)
avatar andrepereiradasilva andrepereiradasilva - change - 2 Nov 2016
Title
Media Version on installation (solves 12711)
Media Version on installation (solves #12711)
avatar andrepereiradasilva andrepereiradasilva - edited - 2 Nov 2016
avatar brianteeman
brianteeman - comment - 3 Nov 2016

Tested successfully - (sha missing)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12713.

avatar jeckodevelopment jeckodevelopment - alter_testresult - 3 Nov 2016 - brianteeman: Tested successfully
avatar jeckodevelopment jeckodevelopment - test_item - 3 Nov 2016 - Tested successfully
avatar jeckodevelopment
jeckodevelopment - comment - 3 Nov 2016

I have tested this item successfully on adcf21b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12713.

avatar andrepereiradasilva
andrepereiradasilva - comment - 3 Nov 2016
avatar jeckodevelopment jeckodevelopment - change - 3 Nov 2016
Status Pending Ready to Commit
avatar jeckodevelopment
jeckodevelopment - comment - 3 Nov 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12713.

avatar joomla-cms-bot joomla-cms-bot - change - 3 Nov 2016
Labels Added: ?
avatar jeckodevelopment jeckodevelopment - change - 3 Nov 2016
Milestone Added:
avatar jeckodevelopment jeckodevelopment - change - 3 Nov 2016
Milestone Added:
Labels
avatar andrepereiradasilva
andrepereiradasilva - comment - 3 Nov 2016

thanks

avatar rdeutz rdeutz - change - 4 Nov 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-11-04 09:11:28
Closed_By rdeutz
avatar rdeutz rdeutz - close - 4 Nov 2016
avatar rdeutz rdeutz - merge - 4 Nov 2016
avatar rdeutz rdeutz - reference | abd6ca8 - 4 Nov 16
avatar rdeutz rdeutz - merge - 4 Nov 2016
avatar rdeutz rdeutz - close - 4 Nov 2016

Add a Comment

Login with GitHub to post a comment