[#12711] - Installation is not adding media version in js
- Closed
- 2 Nov 2016
- Medium
- Build: master
- # 12711
Steps to reproduce the issue
Go to /installation/index.php?view=languages
Check source code.
Expected result
All js files with media version.
example:
<script src="/media/jui/js/jquery.min.js?345kjh345j3h4k34h5k35k34"></script>Actual result
<script src="/media/jui/js/jquery.min.js?"></script>
<script src="/media/jui/js/jquery-noconflict.js?"></script>
<script src="/media/jui/js/jquery-migrate.min.js?"></script>
<script src="/media/jui/js/bootstrap.min.js?"></script>
<script src="/media/jui/js/chosen.jquery.min.js?"></script>
<script src="/media/system/js/core.js?"></script>
<!--[if lt IE 9]><script src="/media/system/js/polyfill.event.js"></script><![endif]-->
<script src="/media/system/js/keepalive.js?"></script>
<script src="/media/system/js/punycode.js?"></script>
<script src="/media/system/js/validate.js?"></script>
<script src="/installation/template/js/installation.js?"></script>System information (as much as possible)
Latest staging
Additional comments
Happens in all installation pages.
It seems installation app does not have media version? @mbabker any clue?
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Title |
|
||||||
| Title |
|
||||||
hum ... so install cannot use media version ... ?
It can if you can come up with a way to give it a value that changes appropriately, then you just set the mediaversion attribute in the array that's passed into the JDocument factory. For production releases, md5_file(JPATH_LIBRARIES . '/cms/version/version.php'); would be enough, but since the version file doesn't change during development until explicit version bumps are made, it's not so simple in between.
ok will check what can be done, anyway we shouldn't also allow an empty media version, so i will fix that too.
For install how about a string that is equal to today. ?02112017
Nice and simple and should solve any issues. It does not need to be version
specific
Good idea! Thinking outside the box Brian!. Maybe with hour and minutes since install shouldnt take more than 1 minute anyway
Kiss always wins
On 2 Nov 2016 9:34 p.m., "andrepereiradasilva" notifications@github.com
wrote:
Good idea! Thinking outside the box Brian!. Maybe with your and minutes
since install shouldnt take more than 1 minute anyway—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12711 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8Z7cOefqlnck3x4WJeulFU94FQ8-ks5q6QICgaJpZM4KnmeZ
.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-02 22:08:35 |
| Closed_By | ⇒ | andrepereiradasilva |
The install web app uses its own code to load in the JDocument instance because there isn't exactly a parameter that can be loaded from the database like the default behavior does in the install app.
Default uses come from JFactory::createDocument() while the install app builds it with InstallationApplicationWeb::loadDocument() and injects into
JFactory::$document