User tests: Successful: Unsuccessful:
Pull Request for Issue #12691.
Removes the notice from the issue.
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
Category | ⇒ | Administration Components |
Title |
|
Title |
|
@laoneo
That patch is done to the wrong file.
In fact, this will work (if we keep using categories...)
diff --git a/administrator/components/com_fields/models/field.php b/administrator/components/com_fields/models/field.php
index f2fee8e..8d8ae2e 100644
--- a/administrator/components/com_fields/models/field.php
+++ b/administrator/components/com_fields/models/field.php
@@ -27,4 +27,22 @@
/**
+ * Batch copy/move command. If set to false,
+ * the batch copy/move command is not supported
+ *
+ * @var string
+ */
+ protected $batch_copymove = 'category_id';
+
+ /**
+ * Allowed batch commands
+ *
+ * @var array
+ */
+ protected $batch_commands = array(
+ 'assetgroup_id' => 'batchAccess',
+ 'language_id' => 'batchLanguage',
+ );
+
+ /**
* Constructor.
*
diff --git a/administrator/components/com_fields/views/fields/tmpl/default_batch_body.php b/administrator/components/com_fields/views/fields/tmpl/default_batch_body.php
index f54cf1e..8d2645c 100644
--- a/administrator/components/com_fields/views/fields/tmpl/default_batch_body.php
+++ b/administrator/components/com_fields/views/fields/tmpl/default_batch_body.php
@@ -28,8 +28,10 @@
</div>
<div class="row-fluid">
- <div class="control-group span6">
- <div class="controls">
- <?php echo JHtml::_('batch.item', $context . '.fields');?>
+ <?php if ($published >= 0) : ?>
+ <div class="control-group span6">
+ <div class="controls">
+ <?php echo JHtml::_('batch.item', $context . '.fields');?>
+ </div>
</div>
- </div>
+ <?php endif; ?>
</div>
Thanks for the patch. I'v adapted it. Does it work now as expected as I couldn't reproduce the issue.
Except for the indentation in default_batch_body (look above), it is fine.
But maintainers discussed and do agree that modifying com_categories as you did is not acceptable, so a solution has to be found there.
This PR has nothing to do with the other discussion. Lets try to focus.
It has everything to do with it, as batch is implemented using com_categories.
What I wanted to say is that we should not discuss it over multiple issues.
In the mean while, thanks for correcting the indent.
I have just moved the since tags to __DEPLOY_VERSION__
;)
I have tested this item
Category | Administration Components | ⇒ | Administration com_fields Components |
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-07 10:25:32 |
Closed_By | ⇒ | laoneo |
That does not work here.