[#12694] - Use new features of JHtml::script and etc...
- Closed
- 4 Nov 2016
- Medium
- Build: staging
- # 12694
- Diff
- okonomiyaki3000:use-new-features
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Use the new features of JHtml::script to set IE conditional scripts and versioned scripts.
Also, set meta data on the document object rather than writing it directly in the template.
Basically this PR removes direct writing of some tags to the document head and lets the the head renderer take care of those things instead.
This does not fix any known bug or make anything noticeably better to the end user but Joomla's included templates should serve as examples to template developers so I think it's a good idea for them to make use of features like this as much as possible.
Testing Instructions
Compare the output html source in the head tag before and after applying this patch. A few tags may have moved around in some inconsequential manner and the uncompressed versions of some scripts may be used which weren't before (applies to debug mode only) but everything should still be there and continue to work exactly as before.
Documentation Changes Required
Nope
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Administration Templates (admin) Installation Front End Templates (site) |
@okonomiyaki3000 please review conflicts with this PR.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-04 00:49:49 |
| Closed_By | ⇒ | okonomiyaki3000 |
This is already done in #12373 that just needs one more tester ....
Update: the metadata part is not done in that pr just the scripts